servo / servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that parsing HTML doesn't trigger a reflow for each child appended #1269

Closed

jdm opened this issue Nov 16, 2013 · 5 comments

Assignees

Labels

A-content/dom A-content/parsers I-perf-slow

Member

jdm commented Nov 16, 2013

Since we now call AppendChild in the parser, it's possible that this is the case.

Contributor

bzbarsky commented Nov 17, 2013

AppendChild shoudn't be triggering reflow on its own in any case, right?

Member Author

jdm commented Nov 17, 2013

Well, it calls content_changed on the document, which could do anything it wanted but right now requests a reflow unconditionally.

Contributor

bzbarsky commented Nov 17, 2013

That seems wrong, sure, but nothing is special about the parser there, right?

Member Author

jdm commented Nov 17, 2013

Correct.

kmcallister mentioned this issue

Stop using AppendChild in the HTML parser #3701

Closed

mbrubeck self-assigned this

mbrubeck added the I-perf-slow label

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Don't force reflow on content changes

1e256f1

This fixes a performance regression caused by the previous patches.  Once we
allowed script and layout to run during parsing, it was running too often
(every time the document changed and called window.reflow).

Fixes servo#1269.

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Don't force reflow on content changes

ee2a61a

This fixes a performance regression caused by the previous patches.  Once we
allowed script and layout to run during parsing, it was running too often
(every time the document changed and called window.reflow).

Fixes servo#1269.

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Don't force reflow on content changes

cb5c186

This fixes a performance regression caused by the previous patches.  Once we
allowed script and layout to run during parsing, it was running too often
(every time the document changed and called window.reflow).

Fixes servo#1269.

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Don't force reflow on content changes

a978e40

This fixes a performance regression caused by the previous patches.  Once we
allowed script and layout to run during parsing, it was running too often
(every time the document changed and called window.reflow).

Fixes servo#1269.

Contributor

brunoabinader commented Oct 23, 2014

@jdm, this seems to be a good use case for specializing content_changed :)

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Don't force reflow on content changes

6d30e20

This fixes a performance regression caused by the previous patches.  Once we
allowed script and layout to run during parsing, it was running too often
(every time the document changed and called window.reflow).

Fixes servo#1269.

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Don't force reflow on content changes

45a753c

This fixes a performance regression caused by the previous patches.  Once we
allowed script and layout to run during parsing, it was running too often
(every time the document changed and called window.reflow).

Fixes servo#1269.

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Don't force reflow on content changes

dc31aa7

This fixes a performance regression caused by the previous patches.  Once we
allowed script and layout to run during parsing, it was running too often
(every time the document changed and called window.reflow).

Fixes servo#1269.

mbrubeck closed this in

f39e01b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.