Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html and /html/browsers/browsing-the-web/navigating-across-documents/013.html and /html/browsers/browsing-the-web/navigating-across-documents/015.html #12797

Closed
jdm opened this issue Aug 10, 2016 · 3 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Aug 10, 2016

This looks like an issue caused by interleaving output?

  ▶ TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/014.html
  │ 
  │ ERROR:script::dom::bindings::error: Error at :0:1 parent.events is undefinedALERT: RESULT: ["/html/browsers/browsing-the-web/navigating-across-documents/014.html",0,null,null,[[" Link with javascript onclick form submission script order ",1,"assert_array_equals: lengths differ, expected 2 got 1","onload<@http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/014.html:9:3\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1402:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1426:20\n"]]]
  └ 
@jdm jdm added the I-intermittent label Aug 10, 2016
@jdm jdm mentioned this issue Aug 10, 2016
4 of 5 tasks complete
@jdm
Copy link
Member Author

@jdm jdm commented Aug 10, 2016

The JS error uses error!, which goes through env_logger which uses writeln! on stderr. The ALERT: comes from console.log, which uses println! and therefore stdout. I'm not sure if there's a way around this.

@splav
Copy link
Contributor

@splav splav commented Aug 10, 2016

Why just not to redirect stderr and stdout to different files?

@jdm
Copy link
Member Author

@jdm jdm commented Aug 10, 2016

That would make us lose terminal output, right? That's a pretty big deal. I think we could get around this by making console.log also take the stderr lock.

@jdm jdm changed the title Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html and /html/browsers/browsing-the-web/navigating-across-documents/013.html Oct 22, 2016
@emilio emilio mentioned this issue Oct 30, 2016
4 of 5 tasks complete
@emilio emilio changed the title Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html and /html/browsers/browsing-the-web/navigating-across-documents/013.html Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html and /html/browsers/browsing-the-web/navigating-across-documents/013.html and /html/browsers/browsing-the-web/navigating-across-documents/015.html Oct 30, 2016
@emilio emilio changed the title Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html and /html/browsers/browsing-the-web/navigating-across-documents/013.html and /html/browsers/browsing-the-web/navigating-across-documents/015.html Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html and /html/browsers/browsing-the-web/navigating-across-documents/013.html and /html/browsers/browsing-the-web/navigating-across-documents/015.html and /html/browsers/browsing-the-web/navigating-across-documents/002.html Nov 6, 2016
@glennw glennw mentioned this issue Nov 15, 2016
3 of 5 tasks complete
@SimonSapin SimonSapin mentioned this issue Nov 15, 2016
3 of 3 tasks complete
@emilio emilio changed the title Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html and /html/browsers/browsing-the-web/navigating-across-documents/013.html and /html/browsers/browsing-the-web/navigating-across-documents/015.html and /html/browsers/browsing-the-web/navigating-across-documents/002.html Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html and /html/browsers/browsing-the-web/navigating-across-documents/013.html and /html/browsers/browsing-the-web/navigating-across-documents/015.html and /html/browsers/browsing-the-web/navigating-across-documents/002.html and /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling.html Nov 20, 2016
@emilio emilio mentioned this issue Nov 20, 2016
3 of 5 tasks complete
@glennw glennw mentioned this issue Nov 22, 2016
0 of 5 tasks complete
@jdm jdm changed the title Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html and /html/browsers/browsing-the-web/navigating-across-documents/013.html and /html/browsers/browsing-the-web/navigating-across-documents/015.html and /html/browsers/browsing-the-web/navigating-across-documents/002.html and /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling.html Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html and /html/browsers/browsing-the-web/navigating-across-documents/013.html and /html/browsers/browsing-the-web/navigating-across-documents/015.html and /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling.html Nov 22, 2016
@jdm jdm changed the title Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html and /html/browsers/browsing-the-web/navigating-across-documents/013.html and /html/browsers/browsing-the-web/navigating-across-documents/015.html and /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling.html Intermittent timeout in /html/browsers/browsing-the-web/navigating-across-documents/014.html and /html/browsers/browsing-the-web/navigating-across-documents/013.html and /html/browsers/browsing-the-web/navigating-across-documents/015.html Nov 22, 2016
bors-servo added a commit that referenced this issue Jun 17, 2017
Hold stderr lock when using stdout through Console APIs.

This addresses a longstanding source of intermittent test failures where the stderr and stdout outputs get interleaved and the test harness becomes confused.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12797
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17360)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.