Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homu doesn't kick off tests anymore and does not merge anything #12825

Closed
Ms2ger opened this issue Aug 12, 2016 · 3 comments
Closed

Homu doesn't kick off tests anymore and does not merge anything #12825

Ms2ger opened this issue Aug 12, 2016 · 3 comments

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Aug 12, 2016

CC @aneeshusa @Manishearth @larsbergstrom @metajack @edunham

Both in Servo and travis-backed repos:

@jdm
Copy link
Member

@jdm jdm commented Aug 12, 2016

If the last Travis run was against the same revision as the requested merge, home has a shortcut mode that doesn't bother redoing the build. This is a good thing.

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Aug 12, 2016

That's not what's happening here -- in that case it explicitly says "test exempted" and merges

@Ms2ger Ms2ger changed the title Homu doesn't kick off tests anymore Homu doesn't kick off tests anymore and doe not merge anything Aug 12, 2016
@Ms2ger Ms2ger changed the title Homu doesn't kick off tests anymore and doe not merge anything Homu doesn't kick off tests anymore and does not merge anything Aug 12, 2016
@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Aug 12, 2016

Fixed! The problem is that the homu directory had permissions root:root but the service is supposed to run as the servo user. I cleaned things up manually, and @aneeshusa is going to work on a PR to ensure our salt rules set up things perfectly from a clean directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.