Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix step 31 of the Request constructor #12845
Closed
Labels
Comments
|
Please make a comment here if you intend to work on this issue. Thank you! |
|
Cc @jeenalee. |
|
I'd like to work on this. Thank you for filing this issue! |
|
Sure. :) |
bors-servo
added a commit
that referenced
this issue
Aug 13, 2016
Fix step 31 of the Request constructor. <!-- Please describe your changes on the following line: --> This PR fixes the step 31 of the Request constructor to fill Request's Headers object and rethrow any exceptions. Additionally, it removes unnecessary line breaks, comments, and redundant function. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12845 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because this PR does not change the behavior of the Request constructor. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> In addition to fixing step 31 of the Request constructor, this commit also: - remove `get_current_url` function, and use `net_request::request`'s built-in `current_url` method - clean up unnecessary line breaks and comments <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12851) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Step 31 says:
But the code just does:
The compiler even rightly complains:
The code for step 31 should be wrapped in
try!().