Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcreate "mach bootstrap" for MSVC builds to download dependencies #12914
Comments
|
I'd very much like it if we either
In both cases if the probe failed we should recommend they download VS. |
1 similar comment
bors-servo
added a commit
that referenced
this issue
Sep 8, 2016
…espeanut Create `mach bootstrap` based on Mozilla's mozboot bootstrapper Fixes #12914 I've made this few weeks ago, its an example how could everything looks like. It downloads and setup all needed dependencies for MSVC. It's has version in case if some dependencies need to be updated. Zip files and folder in zip need to be named ``<dep>-<version>``. Also if cmake already exist in PATH, it won't download it again. I want opinion on that, if this is right approaches and how to improve it. cc @vvuk <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12916) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Sep 8, 2016
…espeanut Create `mach bootstrap` based on Mozilla's mozboot bootstrapper Fixes #12914 I've made this few weeks ago, its an example how could everything looks like. It downloads and setup all needed dependencies for MSVC. It's has version in case if some dependencies need to be updated. Zip files and folder in zip need to be named ``<dep>-<version>``. Also if cmake already exist in PATH, it won't download it again. I want opinion on that, if this is right approaches and how to improve it. cc @vvuk <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12916) <!-- Reviewable:end -->
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Oct 1, 2019
…oot bootstrapper (from UK992:msvc-dependencies); r=larsbergstrom,wafflespeanut Fixes servo/servo#12914 I've made this few weeks ago, its an example how could everything looks like. It downloads and setup all needed dependencies for MSVC. It's has version in case if some dependencies need to be updated. Zip files and folder in zip need to be named ``<dep>-<version>``. Also if cmake already exist in PATH, it won't download it again. I want opinion on that, if this is right approaches and how to improve it. cc vvuk Source-Repo: https://github.com/servo/servo Source-Revision: daa30e60f1a7af87ee88aae4fd6e47e210ee9a76 UltraBlame original commit: f5c0c57f92e6cde5f477d649bf2408b394c90d74
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 1, 2019
…oot bootstrapper (from UK992:msvc-dependencies); r=larsbergstrom,wafflespeanut Fixes servo/servo#12914 I've made this few weeks ago, its an example how could everything looks like. It downloads and setup all needed dependencies for MSVC. It's has version in case if some dependencies need to be updated. Zip files and folder in zip need to be named ``<dep>-<version>``. Also if cmake already exist in PATH, it won't download it again. I want opinion on that, if this is right approaches and how to improve it. cc vvuk Source-Repo: https://github.com/servo/servo Source-Revision: daa30e60f1a7af87ee88aae4fd6e47e210ee9a76 UltraBlame original commit: f5c0c57f92e6cde5f477d649bf2408b394c90d74
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 1, 2019
…oot bootstrapper (from UK992:msvc-dependencies); r=larsbergstrom,wafflespeanut Fixes servo/servo#12914 I've made this few weeks ago, its an example how could everything looks like. It downloads and setup all needed dependencies for MSVC. It's has version in case if some dependencies need to be updated. Zip files and folder in zip need to be named ``<dep>-<version>``. Also if cmake already exist in PATH, it won't download it again. I want opinion on that, if this is right approaches and how to improve it. cc vvuk Source-Repo: https://github.com/servo/servo Source-Revision: daa30e60f1a7af87ee88aae4fd6e47e210ee9a76 UltraBlame original commit: f5c0c57f92e6cde5f477d649bf2408b394c90d74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MSVC Windows builds have a number of dependencies and environment setup. We should create "mach bootstrap" that will automatically download cmake, ninja, openssl, etc. and put them in the .servo dir alongside the compiler and cargo. mach should also set up the proper env vars before building.
The current dependencies and an env setup script are here: http://people.mozilla.org/~vladimir/misc/servo/
cmake and python 2.7 are expected to already be installed.