Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace SVGs with equivalent PNGs in the csswg tests #12963
Comments
|
Many of the tests that use SVG as objects are specifically testing SVGs being embedded in specific places. The complexity of replacing SVGs with bitmapped images is going to be colour spaces, I think. Need to have them match, If there's tests that can easily just have SVGs replaced with images upstream we should just do that. |
Right, but Servo doesn't care about these right now
This was what I was originally thinking about, but the tests aren't easy to edit anymore. Converting on-the-fly lets them stay as editable svgs, but converts them for servo. |
|
@jgraham @gsnedders Are we going to do this? |
A lot of the CSS tests use SVGs as references or as objects to be manipulated.
The references won't run in Servo at all, which makes the test useless in Servo. This also can often lead to false positives when the tested thing doesn't display at all (my multiple backgrounds PR had a bug which cased a lot of tests to pass because of this).
I suspect getting SVG to work in Servo will take a lot of time. We should do that eventually, but I'd like working CSS tests before that.
It occurred to me that we could make the wpt harness replace svgs with pngs (via some flag) using some library. Servo can still mimesniff them and display as pngs, and the reftests will work.
This could make actual SVG tests pass by accident, but that's not important till we actually start supporting SVG (at which point we can revert this change).
If we don't want to do this, we could also just manually replace everything with PNGs, though this requires a more careful audit, and there's probably a reason that all the tests use SVG (PNG might lead to fuzziness?)
cc @SimonSapin @jgraham @gsnedders