Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unnecessary clone from ServiceWorkerManager::prepare_activation #12999
Comments
|
I'm trying :) |
bors-servo
added a commit
that referenced
this issue
Aug 27, 2016
Remove unnecessary clone from ServiceWorkerManager::prepare_activation remove unnecessary for `scope_url` - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12999 - [X] These changes do not require tests because it should works when it compiles <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13076) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Aug 27, 2016
Remove unnecessary clone from ServiceWorkerManager::prepare_activation remove unnecessary for `scope_url` - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12999 - [X] These changes do not require tests because it should works when it compiles <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13076) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right before returning from
prepare_activation, we clonescope_urland pass the result to a function. This is redundant; we should be able to passscope_urlwithout cloning it.Code:
components/script/serviceworker_manager.rsNo need for automated tests; if it builds, it's good enough for a PR.
Note: This is reserved for the upcoming Taiwan Code Sprint; please do not work on it.