Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Stylesheets in Stylist #1300

Closed
pradeep90 opened this issue Nov 22, 2013 · 2 comments
Closed

Store Stylesheets in Stylist #1300

pradeep90 opened this issue Nov 22, 2013 · 2 comments
Labels

Comments

@pradeep90
Copy link
Contributor

@pradeep90 pradeep90 commented Nov 22, 2013

Right now, each Stylesheet is just dropped at the end of add_stylesheet.

We would probably need this to support dynamic style - #976

If this is fine, we can modify Rule to refer to the parent StyleRule's corresponding Selector and the parent's PropertyDeclarations instead of copying them over.

@SimonSapin Do you have any thoughts on this?

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Nov 22, 2013

Yes, we need to preserve Stylesheet objects (or something like them) in order to support #976 or CSSOM.

The question is, how does this interact with other data structures that we keep around for matching (eg. the rule hashes), especially for the lifetime if selectors and declarations?

@jdm
Copy link
Member

@jdm jdm commented May 25, 2016

We definitely keep Stylesheet objects around now, so this issue doesn't really make sense to leave open.

@jdm jdm closed this May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.