Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make URLSearchParams iterable #13022

Closed
jdm opened this issue Aug 24, 2016 · 2 comments
Closed

Make URLSearchParams iterable #13022

jdm opened this issue Aug 24, 2016 · 2 comments
Labels
A-content/dom C-assigned

Comments

@jdm
Copy link
Member

@jdm jdm commented Aug 24, 2016

Blocked on #12819. We're missing iterable<USVString, USVString>; from URLSearchParams.webidl, which will require implementing the Iterable trait for URLSearchParams. See #12998 for an example of doing this.

Code: components/script/dom/webidls/URLSearchParams.webidl, components/script/dom/urlsearchparams.rs
Test: create a test in tests/wpt/web-platform-tests/url that tests the properties of the iterating over a URLSearchParam
@jdm jdm added this to the Taiwan Code Sprint milestone Aug 24, 2016
@yoyo930021
Copy link
Contributor

@yoyo930021 yoyo930021 commented Aug 27, 2016

I try it.
@jdm
Copy link
Member Author

@jdm jdm commented Aug 27, 2016

Great! Ask questions if anything is unclear!
yoyo930021 added a commit to yoyo930021/servo that referenced this issue Aug 27, 2016
@yoyo930021
Make URLSearchParams iterable servo#13022
564cedc
@yoyo930021 yoyo930021 mentioned this issue Aug 27, 2016
Closed
4 of 5 tasks complete
yoyo930021 added a commit to yoyo930021/servo that referenced this issue Aug 27, 2016
@yoyo930021
Make URLSearchParams iterable servo#13022 to delete sort
8a16a43
bors-servo added a commit that referenced this issue Aug 27, 2016
@bors-servo
Auto merge of #13077 - yoyo930021:master, r=<try>
Loading status checks…
638b553 
Make URLSearchParams iterable #13022

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13022  (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13077)
<!-- Reviewable:end -->
yoyo930021 added a commit to yoyo930021/servo that referenced this issue Aug 27, 2016
@yoyo930021
Make URLSearchParams iterable servo#13022 to modify iterable length
2e1d3a5
Ms2ger added a commit that referenced this issue Oct 7, 2016
@yoyo930021 @Ms2ger
Make URLSearchParams iterable.
Loading status checks…
63997f0 
Fixes #13022.
Ms2ger added a commit that referenced this issue Oct 7, 2016
@yoyo930021 @Ms2ger
Make URLSearchParams iterable.
Loading status checks…
980c644 
Fixes #13022.
Fixes #13077.
@Ms2ger Ms2ger mentioned this issue Oct 7, 2016
Merged
bors-servo added a commit that referenced this issue Oct 7, 2016
@bors-servo
Auto merge of #13637 - servo:URLSearchParams, r=emilio
Loading status checks…
b1c5b91 
Make URLSearchParams iterable.

Fixes #13022.
Fixes #13077.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13637)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Make URLSearchParams iterable #13022
2 participants
@jdm @yoyo930021
You can’t perform that action at this time.