Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWe do a lot of testing of ineffective dependencies #13125
Closed
Comments
|
Note that I get this same assertion on the wikipedia front page too. |
|
Stupid assertion added by me yesterday. |
|
s/Stupid/too strict/ |
bors-servo
added a commit
that referenced
this issue
Aug 30, 2016
Fix debug assertion introduced in #13108 by me. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13125 (github issue number if applicable). <!-- Either: --> - [x] These changes do not require tests because #13127 <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> I'm stupid, and when I did the last moving-the-code-around, I failed miserably to double-check it in a debug build. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13128) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
STEPS TO REPRODUCE with revision 8695552:
./mach build -d --debug-mozjs(this last part may not be needed)./mach run -d tests/html/bindings_perf.htmlEXPECTED RESULTS: Load the page.
ACTUAL RESULTS: Load the page, then assert about "Testing a completely ineffective dependency?", then the content process crashes and the browser is in an unusable state.
//cc @emilio