Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement OpenEndedDictionary #13144

Closed
jeenalee opened this issue Aug 31, 2016 · 2 comments
Closed

Implement OpenEndedDictionary #13144

jeenalee opened this issue Aug 31, 2016 · 2 comments
Assignees
@Ms2ger
Labels
A-content/bindings

Comments

@jeenalee
Copy link
Contributor

@jeenalee jeenalee commented Aug 31, 2016

A good portion of web platform tests for dom::headers, dom::request, and dom::response are failing due to missing OpenEndedDictionary implementation.

These failing tests throw the message, (some) dict is not iterable.

OpenEndedDictionary is a future IDL construct, and there is an ongoing discussion about it here.
@jeenalee jeenalee mentioned this issue Sep 1, 2016
Closed
@jdm
Copy link
Member

@jdm jdm commented Sep 1, 2016 •
edited

Gecko's solution to this is the MozMap type (https://dxr.mozilla.org/mozilla-central/source/dom/webidl/Headers.webidl?q=path%3Aheaders.webidl&redirect_type=single#11), which we also do not support yet.
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Sep 15, 2016

I'm looking into this.
@Ms2ger Ms2ger mentioned this issue Sep 15, 2016
Merged
This was referenced Sep 19, 2016
Merged
Merged
Ms2ger added a commit that referenced this issue Sep 20, 2016
@Ms2ger
Implement the MozMap type.
Loading status checks…
594d824 
Fixes #13144.
Ms2ger added a commit that referenced this issue Sep 20, 2016
@Ms2ger
Implement the MozMap type.
Loading status checks…
4b948b5 
Fixes #13144.
@Ms2ger Ms2ger mentioned this issue Sep 20, 2016
Merged
Ms2ger added a commit that referenced this issue Sep 21, 2016
@Ms2ger
Implement the MozMap type.
Loading status checks…
2d83e5a 
Fixes #13144.
bors-servo added a commit that referenced this issue Sep 21, 2016
@bors-servo
Auto merge of #13332 - servo:mozmap, r=jdm
Loading status checks…
7b98c8a 
Implement the MozMap type.

Fixes #13144.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13332)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ms2ger Ms2ger

Labels
A-content/bindings
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @Ms2ger @jeenalee
You can’t perform that action at this time.