Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove support for UTF-16 in TextEncoder #13231
Closed
Labels
Comments
|
Please make a comment here if you intend to work on this issue. Thank you! |
|
I'd like to take this :) |
|
@ashrko619 Did you make progress on this? Any questions? |
|
@jdm I did not know whether to work on this without being assigned |
|
The encoding specification changed so that TextEncoder only ever uses UTF-8 now. That means that we don't need an encoder variable in our implementation any more; we can use the UTF-8 encoder directly everywhere instead. |
bors-servo
added a commit
that referenced
this issue
Sep 24, 2016
Removed support for UTF-16 in TextEncoder <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13231 (github issue number if applicable). <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13405) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Sep 27, 2016
Removed support for UTF-16 in TextEncoder <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13231 (github issue number if applicable). <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13405) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Blocks #5601.
The specification was changed. This should allow us to remove the
encoderfield of theTextEncoderstruct.components/script/dom/textencoder.rs,components/script/dom/webidls/TextEncoder.webidl./encoding/textencoder-constructor-non-utf.html, (possibly)/encoding/idlharness.html.