Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ArrayBuffer overload of TextDecoder::decode. #13236

Closed
Ms2ger opened this issue Sep 12, 2016 · 5 comments
Closed

Implement ArrayBuffer overload of TextDecoder::decode. #13236

Ms2ger opened this issue Sep 12, 2016 · 5 comments

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Sep 12, 2016

Blocks #5601.

@yodalee
Copy link
Contributor

@yodalee yodalee commented Oct 3, 2016

I'm trying to implement this.
Do I need to modify webidls/TextDecoder.webidl and remove this line:

USVString decode(optional object input);

and uncomment this line, and add dictionary TextDecodeOptions

USVString decode(optional BufferSource input, optional TextDecodeOptions options);

Since the former is not in the interface spec: https://encoding.spec.whatwg.org/#interface-textdecoder

@jdm
Copy link
Member

@jdm jdm commented Oct 3, 2016

BufferSource is defined in the WebIDL spec, but our codegen can't handle the the ArrayBufferView or ArrayBuffer types yet. The first argument will need to stay as optional object input until we do.

@nox
Copy link
Member

@nox nox commented Oct 4, 2017

We have codegen for ArrayBuffer now, right?

@jdm
Copy link
Member

@jdm jdm commented Oct 4, 2017

No codegen support yet.

@jdm
Copy link
Member

@jdm jdm commented Mar 23, 2018

Duplicate of #20344.

@jdm jdm closed this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.