Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in the iso-2022-jp decoder? #13239

Closed
Ms2ger opened this issue Sep 12, 2016 · 3 comments
Closed

Bugs in the iso-2022-jp decoder? #13239

Ms2ger opened this issue Sep 12, 2016 · 3 comments
Labels
A-content/dom I-wrong

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Sep 12, 2016

Blocks #5601.

Test: /encoding/iso-2022-jp-decoder.html.

I can't assess the correctness of the test, but it seems likely the underlying bug, if any, is in rust-encoding,

CC @SimonSapin @lifthrasiir
@lifthrasiir
Copy link

@lifthrasiir lifthrasiir commented Sep 12, 2016 •
edited

I believe this hit the WHATWG rewrite (Encoding is not yet very up to date in that regard). Specifically 1B 24 (a lone escape sequence) should be an error in the rewritten algorithm but Encoding happily passes that.
@nox
Copy link
Member

@nox nox commented Oct 4, 2017

Is it the test or the spec or the code that should change?
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Nov 16, 2017

Fixed in #19073.
@SimonSapin SimonSapin closed this Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@Ms2ger @nox @SimonSapin @lifthrasiir
You can’t perform that action at this time.