Return the error codes instead of implicitly returning None

[wafflespeanut]

Some of the methods in testing_commands.py have a returning pattern like,

result = call(...)
if result != 0:
    return result

Instead of doing that check and implicitly returning None, we could just return the result, since 0 and None have the same boolean evaluation in python.

Code: python/servo/testing_commands.py

[highfive]

Please make a comment here if you intend to work on this issue. Thank you!

[wafflespeanut]

Great!

[uber1geek]

I wanted to work on this issue as well :)

[wafflespeanut]

Sorry, @bubbles231 claimed this first. Feel free to poke other unclaimed easy issues, or comment here (or ping us at the #servo channel in the IRC) if you want help :)

[wafflespeanut]

I meant that they both have similar boolean evaluation (i.e) how the __nonzero__ magic method is implemented. In other words,

if None: print 'Hello'
# doesn't print anything
if 0: print 'Hello'
# doesn't print anything

Hence, there's no great reason to prefer None instead of 0 :)

[bubbles231]

un assign me please

[wafflespeanut]

@bubbles231 Thanks for letting us know!

@uber1geek It's yours then! :)

[uber1geek]

@wafflespeanut Return result seems good, I was thinking if we just make it an empty value. it will evaluate to false and that solves the issue imo.

[KiChjang]

I'm not sure what you're trying to get at here. This is what I think is being proposed:

return call(...)

[wafflespeanut]

@uber1geek Any updates on this?

[nivekuil]

I'd like to claim this. Sent a PR.