Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent "Operation not permitted" when killing servo process during test-wpt #13400

Closed
jdm opened this issue Sep 23, 2016 · 6 comments
Closed

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 23, 2016

  ▶ ERROR [expected OK] /websockets/constructor/013.html
  └   → Traceback (most recent call last):
  File "/Users/servo/buildbot/slave/mac-rel-wpt/build/tests/wpt/harness/wptrunner/executors/base.py", line 149, in run_test
    result = self.do_test(test)
  File "/Users/servo/buildbot/slave/mac-rel-wpt/build/tests/wpt/harness/wptrunner/executors/executorservo.py", line 133, in do_test
    self.proc.kill()
  File "/Users/servo/buildbot/slave/mac-rel-wpt/build/python/_virtualenv/lib/python2.7/site-packages/mozprocess/processhandler.py", line 749, in kill
    self.proc.kill(sig=sig)
  File "/Users/servo/buildbot/slave/mac-rel-wpt/build/python/_virtualenv/lib/python2.7/site-packages/mozprocess/processhandler.py", line 165, in kill
    send_sig(signal.SIGTERM)
  File "/Users/servo/buildbot/slave/mac-rel-wpt/build/python/_virtualenv/lib/python2.7/site-packages/mozprocess/processhandler.py", line 152, in send_sig
    os.killpg(pid, sig)
OSError: [Errno 1] Operation not permitted
@jdm jdm added the I-intermittent label Sep 23, 2016
@jdm jdm changed the title i"Operation not permitted" when killing servo process during test-wpt Intermittent "Operation not permitted" when killing servo process during test-wpt Sep 23, 2016
samgiles added a commit to samgiles/servo that referenced this issue Feb 16, 2017
@samgiles
Copy link
Contributor

@samgiles samgiles commented Feb 16, 2017

Pretty sure I found a fix for this. PR incoming!

samgiles added a commit to samgiles/servo that referenced this issue Feb 16, 2017
samgiles added a commit to samgiles/servo that referenced this issue Feb 16, 2017
@samgiles
Copy link
Contributor

@samgiles samgiles commented Feb 16, 2017

Fix is upstream in mozprocess https://bugzilla.mozilla.org/show_bug.cgi?id=1329528.

Needs publish to PyPI

@samgiles
Copy link
Contributor

@samgiles samgiles commented Feb 17, 2017

This has been published to PyPI (0.25),
Looks like the fix should be picked up automatically \o/.

tests/wpt/harness/requirements_chrome.txt
1:mozprocess >= 0.19

tests/wpt/harness/requirements_firefox.txt
3:mozprocess >= 0.19

tests/wpt/harness/requirements_servo.txt
1:mozprocess >= 0.19
@nox
Copy link
Member

@nox nox commented Oct 5, 2017

@jdm Did the change ultimately land in our repo?

@nox nox added the C-is-this-done label Oct 5, 2017
@dralley
Copy link
Contributor

@dralley dralley commented Mar 24, 2020

Bump

@jdm
Copy link
Member Author

@jdm jdm commented Mar 24, 2020

We have a more recent version of mozprocess in use now.

@jdm jdm closed this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.