Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace instances of old ServiceWorker specification URL with new one #13408

Closed
jdm opened this issue Sep 24, 2016 · 5 comments
Closed

Replace instances of old ServiceWorker specification URL with new one #13408

jdm opened this issue Sep 24, 2016 · 5 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 24, 2016

The old specification URL is https://slightlyoff.github.io/ServiceWorker/spec/service_worker/ and there are various places in components/script that use it. We should rewrite all of these instances to use the new specification instead: https://w3c.github.io/ServiceWorker/ . We can also remove the specification exception in https://dxr.mozilla.org/servo/source/python/tidy/servo_tidy/tidy.py#72 . Since all links should exist in comments, all that's necessary is to run ./mach test-tidy before submitting a PR.

@highfive
Copy link

@highfive highfive commented Sep 24, 2016

Please make a comment here if you intend to work on this issue. Thank you!

@vigneshsarma
Copy link
Contributor

@vigneshsarma vigneshsarma commented Sep 24, 2016

I would like to give it a go.

@jdm
Copy link
Member Author

@jdm jdm commented Sep 24, 2016

Great! Please ask questions if anything is unclear :)

@jdm jdm added the C-assigned label Sep 24, 2016
@vigneshsarma
Copy link
Contributor

@vigneshsarma vigneshsarma commented Sep 25, 2016

Before I submit the PR,

  1. Why is it that it is ok to remove the line https://dxr.mozilla.org/servo/source/python/tidy/servo_tidy/tidy.py#72? I don't really understand what's going on here.
  2. I also found references to this url in tests/wpt/web-platform-tests/service-workers/stub-*, tests/wpt/web-platform-tests/service-workers/cache-storage/ and some other files in tests. Should I update them also?
@jdm
Copy link
Member Author

@jdm jdm commented Sep 25, 2016

  1. That's the list of URLs hostnames that point to known specifications, which tidy.py uses to validate that certain files and methods contain comments linking to a specification that they're implementing. Since no specification exists at slightlyoff.github.io/ServiceWorker/ any more, we don't want people accidentally adding links to it after this point.
  2. Yes, that would be helpful! The whole web-platform-tests directory is a clone of https://github.com/w3c/web-platform-tests/, but any changes we make will automatically be duplicated upstream.
bors-servo added a commit that referenced this issue Sep 25, 2016
Replace instances of old ServiceWorker specification URL with new one

<!-- Please describe your changes on the following line: -->

The old specification URL is
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/, which has
been replaced by the new one at https://w3c.github.io/ServiceWorker/.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13408 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because all the changes are in commented parts of the code.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

The old specification URL is
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/ has
been replaced by the new one at https://w3c.github.io/ServiceWorker/.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13416)
<!-- Reviewable:end -->
@CYBAI CYBAI mentioned this issue Nov 4, 2018
3 of 3 tasks complete
bors-servo added a commit that referenced this issue Nov 4, 2018
Update to new ServiceWorker spec link

I think this is missing in #13408

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it just updates the spec link

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22107)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.