Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace instances of old ServiceWorker specification URL with new one #13408
Labels
Comments
|
Please make a comment here if you intend to work on this issue. Thank you! |
|
I would like to give it a go. |
|
Great! Please ask questions if anything is unclear :) |
|
Before I submit the PR,
|
|
bors-servo
added a commit
that referenced
this issue
Sep 25, 2016
Replace instances of old ServiceWorker specification URL with new one <!-- Please describe your changes on the following line: --> The old specification URL is https://slightlyoff.github.io/ServiceWorker/spec/service_worker/, which has been replaced by the new one at https://w3c.github.io/ServiceWorker/. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13408 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because all the changes are in commented parts of the code. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> The old specification URL is https://slightlyoff.github.io/ServiceWorker/spec/service_worker/ has been replaced by the new one at https://w3c.github.io/ServiceWorker/. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13416) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Nov 4, 2018
Update to new ServiceWorker spec link I think this is missing in #13408 --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it just updates the spec link <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22107) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The old specification URL is https://slightlyoff.github.io/ServiceWorker/spec/service_worker/ and there are various places in
components/scriptthat use it. We should rewrite all of these instances to use the new specification instead: https://w3c.github.io/ServiceWorker/ . We can also remove the specification exception in https://dxr.mozilla.org/servo/source/python/tidy/servo_tidy/tidy.py#72 . Since all links should exist in comments, all that's necessary is to run./mach test-tidybefore submitting a PR.