Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Location.replace #13413

Closed
KiChjang opened this issue Sep 25, 2016 · 3 comments
Closed

Implement Location.replace #13413

KiChjang opened this issue Sep 25, 2016 · 3 comments
Labels
A-content/dom C-assigned C-has open PR E-easy I-enhancement

Comments

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Sep 25, 2016 •
edited

This would allow us to click links on Google search.

Should be a straightfoward implementation - refer to the implementation of fn Assign if it's not clear.

Spec: https://html.spec.whatwg.org/multipage/browsers.html#dom-location-replace
Files: components/script/dom/webidls/Location.webidl, components/script/dom/location.rs
Test: tests/wpt/web-platform-tests/html/browsers/history/the-location-interface/location_replace.html
@highfive
Copy link

@highfive highfive commented Sep 25, 2016

Please make a comment here if you intend to work on this issue. Thank you!
@stshine
Copy link
Contributor

@stshine stshine commented Sep 25, 2016

I'd like to have a try.
@jdm
Copy link
Member

@jdm jdm commented Sep 25, 2016

Please do!
@jdm jdm added the C-assigned label Sep 25, 2016
@stshine stshine mentioned this issue Sep 25, 2016
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Sep 25, 2016
@bors-servo
Auto merge of #13418 - stshine:location-replace, r=<try>
Loading status checks…
8a018c0 
Implement Location.replace()

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13413 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13418)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Sep 26, 2016
@bors-servo
Auto merge of #13418 - stshine:location-replace, r=<try>
Loading status checks…
d0e866e 
Implement Location.replace()

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13413 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13418)
<!-- Reviewable:end -->
@jdm jdm mentioned this issue Oct 14, 2016
Closed
@nox nox changed the title Implement Location#Replace Implement Location.replace Oct 14, 2016
@Ms2ger Ms2ger mentioned this issue Oct 27, 2016
Open
9 of 13 tasks complete
@jdm jdm added the C-has open PR label Nov 4, 2016
bors-servo added a commit that referenced this issue Nov 18, 2016
@bors-servo
Auto merge of #13418 - stshine:location-replace, r=<try>
Loading status checks…
d20243e 
Make document url mutable and implement location.replace()

<!-- Please describe your changes on the following line: -->

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13413 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13418)

<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 19, 2016
@bors-servo
Auto merge of #13418 - stshine:location-replace, r=KiChjang
Loading status checks…
b814390 
Make document url mutable and implement location.replace()

<!-- Please describe your changes on the following line: -->

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13413 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13418)

<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 19, 2016
@bors-servo
Auto merge of #13418 - stshine:location-replace, r=KiChjang
Loading status checks…
1d1b742 
Make document url mutable and implement location.replace()

<!-- Please describe your changes on the following line: -->

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13413 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13418)

<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 19, 2016
@bors-servo
Auto merge of #13418 - stshine:location-replace, r=KiChjang
Loading status checks…
b8cb92a 
Make document url mutable and implement location.replace()

<!-- Please describe your changes on the following line: -->

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13413 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13418)

<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 20, 2016
@bors-servo
Auto merge of #13418 - stshine:location-replace, r=KiChjang
Loading status checks…
debad8a 
Make document url mutable and implement location.replace()

<!-- Please describe your changes on the following line: -->

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13413 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13418)

<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 20, 2016
@bors-servo
Auto merge of #13418 - stshine:location-replace, r=KiChjang
Loading status checks…
72e4c6d 
Make document url mutable and implement location.replace()

<!-- Please describe your changes on the following line: -->

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13413 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13418)

<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned C-has open PR E-easy I-enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Make document url mutable and implement location.replace()
4 participants
@jdm @stshine @KiChjang @highfive
You can’t perform that action at this time.