Have tidy ensure that the there are no extra files in the webidls folder

[Manishearth]

We should probably lint that components/script/dom/webidls contains only *.webidl files.

Code: https://github.com/servo/servo/blob/master/python/tidy/servo_tidy/tidy.py

[highfive]

cc @wafflespeanut

[highfive]

Please make a comment here if you intend to work on this issue. Thank you!

[gterzian]

@Manishearth could this be already implemented through https://github.com/servo/servo/blob/master/python/tidy/servo_tidy/tidy.py#L570 ?

[wafflespeanut]

@gterzian No, that checks the contents of the webidl files. We probably need a new function for doing that check.

[gterzian]

@wafflespeanut ok thanks for clarifying. Allright I'll give this one a try

[wafflespeanut]

Glad to hear :)

[gterzian]

@wafflespeanut @Manishearth

A question:

do we want to check for any type of 'unwanted' file inside components/script/dom/webidls or limit ourselves to the subset of FILE_PATTERNS_TO_CHECK see https://github.com/servo/servo/blob/master/python/tidy/servo_tidy/tidy.py#L44

I'm mainly asking because if we limit ourselves to FILE_PATTERNS_TO_CHECK, I can just plug into the existing 'file checking' generator pipeline from https://github.com/servo/servo/blob/master/python/tidy/servo_tidy/tidy.py#L834, for example by checking that every file ending in *.webidl is in the right folder, otherwise I think I'll have to do a completely separate check, which I guess would mean a separate run over every file in that folder.

Personally I'de like to just add a step to the existing generator pipeline...

[Manishearth]

@gterzian We want to ensure that this folder has only *.webidl files. webidl files elsewhere in the tree are okay (usually meaningless). Since the webidl files in that folder are read by the bindings generator, any other kind of file there is probably a mistake.

This is a different kind of check from the rest, let it stay completely separate.

[gterzian]

@Manishearth ok, thanks for the extra background info, that's all I need to get started :)

so I'll just add another step, akin to the config error check, that is unrelated to the generator pipeline that checks all files individually.