Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTests in /fetch/api/cors/ and /fetch/api/redirect/ intermittently time out #13441
Labels
Comments
bors-servo
added a commit
that referenced
this issue
Nov 4, 2016
bors-servo
added a commit
that referenced
this issue
Nov 4, 2016
Enable cors and redirect fetch tests. There have been a bunch of changes to the fetch code since #13441 was filed, and the results seem more stable now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14070) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Nov 5, 2016
Enable cors and redirect fetch tests. There have been a bunch of changes to the fetch code since #13441 was filed, and the results seem more stable now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14070) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Nov 5, 2016
Enable cors and redirect fetch tests. There have been a bunch of changes to the fetch code since #13441 was filed, and the results seem more stable now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14070) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Nov 6, 2016
Enable cors and redirect fetch tests. There have been a bunch of changes to the fetch code since #13441 was filed, and the results seem more stable now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14070) <!-- Reviewable:end -->
|
This looks like another instance of tests that spawn a lot of threads timing out under heavy load - cors-redirect.js tests five different response codes, performs four tests per code, and each test performs two fetches. That's forty fetches, and each one creates at least one thread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is tracking the work to investigate why, fix the problem, and re-enable the test directories.