Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation items at the top of nbc.com overlap one another horizontally #13495

Closed
pcwalton opened this issue Sep 29, 2016 · 5 comments
Closed

Navigation items at the top of nbc.com overlap one another horizontally #13495

pcwalton opened this issue Sep 29, 2016 · 5 comments
Labels
A-layout/block A-layout/floats C-has-manual-testcase I-wrong

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Sep 29, 2016

The text is all smushed together—layout considers the floats to have the wrong widths. Each item seems to have float: left and the elements inside form stacking contexts in various ways.
@stshine
Copy link
Contributor

@stshine stshine commented Oct 6, 2016

Here is a minimal test case:

<!DOCTYPE html>
<html>
    <head>
        <style>
         ul {
             position: absolute;
         }
         li {
             float: left;
             list-style-type: none;
         }
        </style>
    </head>
    <body>
        <span id="container">
            <ul>
                <li>Alpha</li>
                <li>Beta</li>
                <li>Garmma</li>
            </ul>
        </span>
    </body>
</html>
@stshine
Copy link
Contributor

@stshine stshine commented Oct 7, 2016 •
edited

What's most interesting here is that this only happens when <ul> is wrapped in an inline element. Looks like a bug in the interaction of out-of-flow block and inline-block split.
@stshine
Copy link
Contributor

@stshine stshine commented Oct 7, 2016

I'd like to work on this.
@pcwalton
Copy link
Contributor Author

@pcwalton pcwalton commented Oct 7, 2016

Go for it! I suspect it's inline hypothetical box related.
@stshine stshine mentioned this issue Apr 8, 2017
Closed
3 of 4 tasks complete
bors-servo added a commit that referenced this issue Apr 8, 2017
@bors-servo
Auto merge of #16310 - stshine:block-formatting-context, r=<try>
Loading status checks…
a001004 
layout: Ensure abs-pos elements establish block formatting contexts

<!-- Please describe your changes on the following line: -->

Per CSS 2.1 § 9.4.1, absolutely positioned elements establish new
block formatting contexts for their contents.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13495 (github issue number if applicable).

<!-- Either: -->
- [] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16310)
<!-- Reviewable:end -->
@nox
Copy link
Member

@nox nox commented Oct 5, 2017

This still happens.
@paulrouget paulrouget mentioned this issue Nov 14, 2019
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Nov 14, 2019
@bors-servo
Auto merge of #24736 - paulrouget:layoutissue, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
df884ad 
layout: Ensure abs-pos elements establish block formatting contexts

Updating #16310

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13495 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Nov 15, 2019
@bors-servo
Auto merge of #24736 - paulrouget:layoutissue, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
04ff252 
layout: Ensure abs-pos elements establish block formatting contexts

Updating #16310

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13495 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Nov 16, 2019
@bors-servo
Auto merge of #24736 - paulrouget:layoutissue, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
df866ef 
layout: Ensure abs-pos elements establish block formatting contexts

Updating #16310

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13495 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Nov 16, 2019
@bors-servo
Auto merge of #24736 - paulrouget:layoutissue, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1c49889 
layout: Ensure abs-pos elements establish block formatting contexts

Updating #16310

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13495 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Nov 16, 2019
@bors-servo
Auto merge of #24736 - paulrouget:layoutissue, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
858b35e 
layout: Ensure abs-pos elements establish block formatting contexts

Updating #16310

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13495 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/block A-layout/floats C-has-manual-testcase I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

layout: Ensure abs-pos elements establish block formatting contexts
layout: Ensure abs-pos elements establish block formatting contexts
3 participants
@nox @pcwalton @stshine
You can’t perform that action at this time.