Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in CEF build time #13591

Closed
larsbergstrom opened this issue Oct 5, 2016 · 3 comments
Closed

Regression in CEF build time #13591

larsbergstrom opened this issue Oct 5, 2016 · 3 comments
Labels
A-build

Comments

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Oct 5, 2016

As of http://build.servo.org/builders/linux-rel-css/builds/23, the CEF build now rebuilds the entire tree. This is due to:
19a5a30#diff-4b02cf15724590179b4a5025f1a81a0dR223

With that line, I believe that the default release build and the CEF build have different -C flags. There are a few options here:

  1. Move the CEF build to the other build flavor
  2. Build CEF with that flag

It seems like #2 might be useful if we think we will start testing CEF, but #1 is definitely the easy one :-)

CC @nox @emilio
@larsbergstrom
Copy link
Contributor Author

@larsbergstrom larsbergstrom commented Oct 5, 2016

Oh, duh, #1 won't work because we set this flag in both linux-rel builders :-)
@larsbergstrom larsbergstrom mentioned this issue Oct 5, 2016
Merged
bors-servo added a commit that referenced this issue Oct 5, 2016
@bors-servo
Auto merge of #13601 - larsbergstrom:debug_assertions_cef, r=nox
Loading status checks…
9c26101 
Ensure that SERVO_ENABLE_DEBUG_ASSERTIONS is also used in build-cef

r? @nox

Fixes #13591

This fixes the problem with rebuilding all of CEF on the linux-rel builders by ensuring it gets the same `RUSTFLAGS`. Proof:
```
[larsberg@larsberg servo2]$ ./mach build-cef -r
   Compiling embedding v0.0.1 (file:///Users/larsberg/servo2/ports/cef)
    Finished release [optimized] target(s) in 35.42 secs
[Warning] Could not generate notification! Optional Python module 'pyobjc' is not installed.
CEF build completed in 0:00:38
[larsberg@larsberg servo2]$
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13601)
<!-- Reviewable:end -->
@emilio
Copy link
Member

@emilio emilio commented Oct 5, 2016

Thanks for taking care of this Lars! I meant to get to this today but I
couldn't finally :/

On Wed, Oct 05, 2016 at 09:10:36AM -0700, bors-servo wrote:

Closed #13591 via #13601.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#13591 (comment)
@larsbergstrom
Copy link
Contributor Author

@larsbergstrom larsbergstrom commented Oct 5, 2016

np! It was so easy that even I could do it :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Ensure that SERVO_ENABLE_DEBUG_ASSERTIONS is also used in build-cef
2 participants
@larsbergstrom @emilio
You can’t perform that action at this time.