Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upJumpiness involving floats on Wikipedia and elsewhere #13630
Closed
Comments
|
Based on some other suspicious cases I think we shouldn't rule out restyling going wrong either. |
|
Complete guess in the dark: It may be that floats-in/floats-out data is not properly preserved across incremental reflows. |
|
Minimal test case: |
pcwalton
added a commit
to pcwalton/servo
that referenced
this issue
Oct 11, 2016
placing block formatting contexts in the sequential fallback. The existing block position isn't yet computed at that time, so it contains junk data. It just so happened to work on first reflow because that value is usually set to zero, but it usually failed on subsequent reflows. Improves certain Wikipedia pages. Closes servo#13630 (though Google is still broken; it was a separate bug and will be split off into a separate issue).
bors-servo
added a commit
that referenced
this issue
Oct 11, 2016
…cement, r=notriddle layout: Don't use the existing block position as the float ceiling when placing block formatting contexts in the sequential fallback. The existing block position isn't yet computed at that time, so it contains junk data. It just so happened to work on first reflow because that value is usually set to zero, but it usually failed on subsequent reflows. Improves certain Wikipedia pages. Closes #13630 (though Google is still broken; it was a separate bug and will be split off into a separate issue). r? @notriddle <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13685) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Oct 11, 2016
…cement, r=notriddle layout: Don't use the existing block position as the float ceiling when placing block formatting contexts in the sequential fallback. The existing block position isn't yet computed at that time, so it contains junk data. It just so happened to work on first reflow because that value is usually set to zero, but it usually failed on subsequent reflows. Improves certain Wikipedia pages. Closes #13630 (though Google is still broken; it was a separate bug and will be split off into a separate issue). r? @notriddle <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13685) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Go to http://en.wikipedia.org/wiki/Pine_marten with
--resolution=1280x800. Notice that "Habitat" is incorrectly drawn on top of the float. Note also that mousing over "Habitat" fixes the rendering briefly before it returns to its incorrect state.Possibly related: Go to http://google.com/ and mouse over the top bar. Observe jumpiness there too.
Making a minimal test case would be very valuable :)