Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent crash in /_mozilla/webgl/conformance-1.0.3/conformance/more/glsl/uniformOutOfBounds.html #13662

Closed
nox opened this issue Oct 9, 2016 · 3 comments

Comments

@nox
Copy link
Member

@nox nox commented Oct 9, 2016

Tests with unexpected results:
  ▶ ERROR [expected OK] /webgl/conformance-1.0.3/conformance/more/glsl/uniformOutOfBounds.html
  └   → Traceback (most recent call last):
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/executors/base.py", line 149, in run_test
    result = self.do_test(test)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/tests/wpt/harness/wptrunner/executors/executorservo.py", line 133, in do_test
    self.proc.kill()
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/python/_virtualenv/lib/python2.7/site-packages/mozprocess/processhandler.py", line 749, in kill
    self.proc.kill(sig=sig)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/python/_virtualenv/lib/python2.7/site-packages/mozprocess/processhandler.py", line 165, in kill
    send_sig(signal.SIGTERM)
  File "/Users/servo/buildbot/slave/mac-rel-wpt2/build/python/_virtualenv/lib/python2.7/site-packages/mozprocess/processhandler.py", line 152, in send_sig
    os.killpg(pid, sig)
OSError: [Errno 1] Operation not permitted
@nox
Copy link
Member Author

@nox nox commented Jul 7, 2018

Just tried it right now, it says:

 0:07.61 pid:37110 ERROR 2018-07-07T22:04:13Z: canvas::webgl_thread: Last GL operation failed: Uniform3fv(0, [0.0, 1.0, 2.0])
 0:07.61 pid:37110 assertion failed: `(left == right)`
 0:07.62 pid:37110   left: `1282`,
 0:07.62 pid:37110  right: `0`: Unexpected WebGL error: 0x502 (1282) (thread WebGLThread, at components/canvas/webgl_thread.rs:985)
 0:07.68 TEST_END: Test OK. Subtests passed 1/1. Unexpected 0

and then it succeeds, so we should probably keep it disabled for now.

bors-servo added a commit that referenced this issue Jul 26, 2018
Allow webgl tests using unit test harness to run to completion.

This is an equivalent change to 5af2603 that affects a subset of webgl tests that use a different test harness.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13662
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21249)
<!-- Reviewable:end -->
@nox
Copy link
Member Author

@nox nox commented Jul 27, 2018

I fixed this when I implemented getUniform and fixed getUniformLocation, will reenable.

@jdm
Copy link
Member

@jdm jdm commented Jul 27, 2018

I have a PR open that reenables it.

bors-servo added a commit that referenced this issue Jul 27, 2018
Allow webgl tests using unit test harness to run to completion.

This is an equivalent change to 5af2603 that affects a subset of webgl tests that use a different test harness.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13662 fix #10656
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21249)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 28, 2018
Allow webgl tests using unit test harness to run to completion.

This is an equivalent change to 5af2603 that affects a subset of webgl tests that use a different test harness.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13662 fix #10656
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21249)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.