Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ServoParser store a VecDeque for its pending input #13690

Closed
nox opened this issue Oct 11, 2016 · 4 comments
Closed

Make ServoParser store a VecDeque for its pending input #13690

nox opened this issue Oct 11, 2016 · 4 comments
Labels
A-content/dom A-content/parsers C-assigned E-easy I-enhancement

Comments

@nox
Copy link
Member

@nox nox commented Oct 11, 2016

One should wait for #13675 to land first.

The field ServoParser::pending_input should be a DOMRefCell<VeqDeque<String>>, this lets us use VecDeque::pop_front instead of Vec::remove in ServoParser::take_next_input_chunk.

Files:

  • components/script/dom/servoparser/mod.rs
@highfive
Copy link

@highfive highfive commented Oct 11, 2016

Please make a comment here if you intend to work on this issue. Thank you!
@gterzian
Copy link
Member

@gterzian gterzian commented Oct 11, 2016

Ok I'd like to take a pass :)
@nox nox added the C-assigned label Oct 11, 2016
@nox
Copy link
Member Author

@nox nox commented Oct 11, 2016 •
edited

Sure! Be sure to wait for #13675 to land or at least to base your work on top of it.
@gterzian
Copy link
Member

@gterzian gterzian commented Oct 11, 2016

@nox cheers 👍
@gterzian gterzian mentioned this issue Oct 16, 2016
Merged
3 of 5 tasks complete
bors-servo added a commit that referenced this issue Oct 16, 2016
@bors-servo
Auto merge of #13785 - gterzian:use_veqdequeu_in_servoparser, r=nox
Loading status checks…
0b697c1 
switch to using DOMRefCell<VeqDeque<String>> for ServoParser::pending…

<!-- Please describe your changes on the following line: -->
The field ServoParser::pending_input should be a DOMRefCell<VeqDeque<String>>, this lets us use VecDeque::pop_front instead of Vec::remove in ServoParser::take_next_input_chunk.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13690 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

…_input

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13785)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom A-content/parsers C-assigned E-easy I-enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

switch to using DOMRefCell<VeqDeque<String>> for ServoParser::pending…
3 participants
@nox @gterzian @highfive
You can’t perform that action at this time.