Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't compress text nodes across NodeRange boundaries #137

Closed
burg opened this issue Oct 20, 2012 · 2 comments
Closed

Don't compress text nodes across NodeRange boundaries #137

burg opened this issue Oct 20, 2012 · 2 comments
Labels
A-platform/shaping I-wrong

Comments

@burg
Copy link

@burg burg commented Oct 20, 2012

The TextRunScanner will lose node-box mappings if it compresses several NodeRanges to the same text box.
@burg
Copy link
Author

@burg burg commented Oct 22, 2012

This is mostly fixed now, but need to repair mappings if some text nodes got elided by text_transform.
@burg
Copy link
Author

@burg burg commented Oct 23, 2012

Done.
@burg burg closed this Oct 23, 2012
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
@jgraham
Merge pull request servo#137 from dontcallmedom/master
505bc15 
Updated README to match more closely reality
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
@gw3583
Rely on the overflow rect for layer size.
0634b35 
This is not currently correct for layers with transformed elements.

According to the spec, the overflow rect should include transformed elements, so this will need to be added/fixed in the layout code rather than WR.

Fixes servo#137.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-platform/shaping I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@burg
You can’t perform that action at this time.