Remove ResponseAction #13717

Closed
Ms2ger opened this Issue Oct 12, 2016 · 4 comments

Projects

None yet

5 participants

@Ms2ger
Contributor
Ms2ger commented Oct 12, 2016

It seems to be mostly, if not entirely, redundant with FetchResponseMsg.

@KiChjang KiChjang added the E-easy label Dec 13, 2016
@highfive

Please make a comment here if you intend to work on this issue. Thank you!

@KiChjang
Member
KiChjang commented Dec 13, 2016 edited

This looks like it's not even being referenced/used anywhere else except for one file location. We'll need to be careful about how we translate the existing enum to FetchResponseMsg, however.

Code: components/net/image_cache_thread.rs

No need for tests; if it compiles, it's good for a PR.

@deror1869107
Contributor

Hi! I would like to work on this issue.

@KiChjang
Member

Go right ahead! Ask questions here or on irc.mozilla.org at #servo if you have any!

@KiChjang KiChjang added the C-assigned label Dec 14, 2016
@deror1869107 deror1869107 referenced this issue Dec 14, 2016
Merged

Remove-ResponseAction #14586

4 of 5 tasks complete
@bors-servo bors-servo added a commit that referenced this issue Dec 15, 2016
@bors-servo bors-servo Auto merge of #14586 - deror1869107:Remove-ResponseAction, r=jdm
Remove-ResponseAction

<!-- Please describe your changes on the following line: -->
Remove the old Enum ResponseAction and use net_traits::FetchResponseMsg instead.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13717 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because @KiChjang said so.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14586)
<!-- Reviewable:end -->
fde9ac1
@bors-servo bors-servo closed this in #14586 Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment