Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geckolib unit tests are busted #13721

Closed
jdm opened this issue Oct 12, 2016 · 4 comments
Closed

Geckolib unit tests are busted #13721

jdm opened this issue Oct 12, 2016 · 4 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 12, 2016

It's not clear to me why this is broken on Travis and isn't showing up on builders.

./mach test-geckolib
error: use of extern static requires unsafe function or block (error E0133)
    --> /home/travis/build/servo/servo/target/debug/build/style-b398ea74b908472c/out/gecko_properties.rs:6306:46
     |
6306 |             Some(number) => cmp::min(number, nsStyleColumn_kMaxColumnCount),
     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
     = note: for more information, see issue 36247 <https://github.com/rust-lang/rust/issues/35112>
note: lint level defined here
    --> /home/travis/build/servo/servo/components/style/lib.rs:35:9
     |
35   | #![deny(warnings)]
     |         ^^^^^^^^
error: aborting due to previous error
error: Could not compile `style`.
To learn more, run the command again with --verbose.
The command "./mach test-geckolib" exited with 101.
@highfive
Copy link

@highfive highfive commented Oct 12, 2016

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 12, 2016

@bholley turned on #[deny(warnings)] in another PR, that might have caused this? Perhaps we should #[allow(warnings)] for that file?

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 12, 2016

Oh, wait, that's in a macro and that doesn't work. Right.

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 12, 2016

This happens because test-geckolib wrongly runs in a Servo build env, using the servo nightly and the servo target dir, instead of the geckolib stable + geckolib target dir. The latest compiler is whinier about the warnings (see comment in style/lib.rs), hence the error.

test-geckolib doesn't do anything anymore -- it's obsolete now that the crates have been merged. Removed in #13722

bors-servo added a commit that referenced this issue Oct 12, 2016
Remove test-geckolib, run test-stylo on travis

test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in `tests/unit/stylo`. (`./mach test-stylo) Now test-geckolib does nothing.

Fixes #13721
r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13722)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 13, 2016
Remove test-geckolib, run test-stylo on travis

test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in `tests/unit/stylo`. (`./mach test-stylo) Now test-geckolib does nothing.

Fixes #13721
r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13722)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 13, 2016
Remove test-geckolib, run test-stylo on travis

test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in `tests/unit/stylo`. (`./mach test-stylo) Now test-geckolib does nothing.

Fixes #13721
r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13722)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 13, 2016
Remove test-geckolib, run test-stylo on travis

test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in `tests/unit/stylo`. (`./mach test-stylo) Now test-geckolib does nothing.

Fixes #13721
r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13722)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.