Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGeckolib unit tests are busted #13721
Closed
Labels
Comments
|
cc @aneeshusa |
|
@bholley turned on |
|
Oh, wait, that's in a macro and that doesn't work. Right. |
|
This happens because test-geckolib doesn't do anything anymore -- it's obsolete now that the crates have been merged. Removed in #13722 |
bors-servo
added a commit
that referenced
this issue
Oct 12, 2016
Remove test-geckolib, run test-stylo on travis test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in `tests/unit/stylo`. (`./mach test-stylo) Now test-geckolib does nothing. Fixes #13721 r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13722) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Oct 13, 2016
Remove test-geckolib, run test-stylo on travis test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in `tests/unit/stylo`. (`./mach test-stylo) Now test-geckolib does nothing. Fixes #13721 r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13722) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Oct 13, 2016
Remove test-geckolib, run test-stylo on travis test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in `tests/unit/stylo`. (`./mach test-stylo) Now test-geckolib does nothing. Fixes #13721 r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13722) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Oct 13, 2016
Remove test-geckolib, run test-stylo on travis test-geckolib used to do things, but almost all of geckolib has been moved to the style crate, with the tests in `tests/unit/stylo`. (`./mach test-stylo) Now test-geckolib does nothing. Fixes #13721 r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13722) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's not clear to me why this is broken on Travis and isn't showing up on builders.