Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop sharing @mut Attr between script and layout threads #1386

Closed
jdm opened this issue Dec 12, 2013 · 3 comments
Closed

Stop sharing @mut Attr between script and layout threads #1386

jdm opened this issue Dec 12, 2013 · 3 comments
Labels
A-content/dom A-layout/uncategorized

Comments

@jdm
Copy link
Member

@jdm jdm commented Dec 12, 2013

This is bad news. They belong to the script task like any other DOM object, and the layout task happily calls Element::get_attr which happily grubs around the list and performs addrefs and releases.
@jdm jdm mentioned this issue Dec 12, 2013
Closed
@tetsuharuohzeki
Copy link
Member

@tetsuharuohzeki tetsuharuohzeki commented Dec 12, 2013

Do we convert from @mut to extra::arc to fix this thing?
@jdm
Copy link
Member Author

@jdm jdm commented Dec 12, 2013

I think the proper fix is to perform the JSManaged conversion I described on the mailing list.
@jdm
Copy link
Member Author

@jdm jdm commented Apr 1, 2014

JS types exist now.
@jdm jdm closed this Apr 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom A-layout/uncategorized
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @tetsuharuohzeki
You can’t perform that action at this time.