Fix linear gradient's specified form

[canova]

Currently linear gradient is not preserving the current corner directions if just one corner is specified. We should fix thix. The specified form of the linear gradient should preserve the corners and it should convert to angle in ToComputedValue implementation.

To give a more details, you need to convert this enum's HorizontalDirection and VerticalDirection to Option<HorizontalDirection> and Option<HorizontalDirection> and set it here directly without converting to Angle.

This corner to angle conversion should be moved to ToComputedValue implementation, to do this you should remove this line and write the implementation in components/style/values/computed/image.rs GradientKind implemetation should give a hint to how to do it.

Also you can see this part of the Property hacking guide to see how to implement a ToComputedValue conversion.

It may require some additional changes but compile errors will give you hint about that. And of course you can ask here if you have any questions.

[canova]

@AVGP Are you still working on this? You can ask here if you have any questions.

[AVGP]

Absolutely, sorry that it takes me so long, just swamped with work but
should get a chance later this week

Am 07.11.2016 10:04 vorm. schrieb "Nazım Can Altınova" <
notifications@github.com>:

@AVGP https://github.com/AVGP Are you still working on this? You can
ask here if you have any questions.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13892 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAWmRkrZ_o5Ij5pwhk7VwJ4-kK7oHJqeks5q7um2gaJpZM4Kd2-4
.

[KiChjang]

@AVGP next week never came...

[DominoTree]

I'd like to give this one a shot

[canova]

@DominoTree Sure, go ahead! Btw, the links were showing wrong lines because of code changes over time. Updated them. You can ask here if something is unclear.

[DominoTree]

@canaltinova I've been hacking on this some but I'm having trouble wrapping my head around it as a whole. Could you take a look at master...DominoTree:master and see if it looks like I'm moving in the right direction or if anything jumps out at you? Right now, I'm trying to figure out the parse method.

[canova]

@DominoTree Looks like you're in the right path! You need to also remove AngleOrCorner from here and create an AngleOrCorner enum in computed part like this one(Sorry I forgot to mention that):

pub enum AngleOrCorner {
    Angle(Angle),
    Corner(HorizontalDirection, VerticalDirection),
}

In this way we have 2 AngleOrCorner enums, one is computed and one is specified. Computed AngleOrCorner should be like the old specified one as above. You can undo your changes in components/layout/display_list_builder.rs after you changed that. We don't change the behavior of the computed AngleOrCorner. You need to convert specified::AngleOrCorner to computed::AngleOrCorner in ToComputedValue implementation.

+            //TODO: do I need to worry about this?
+            AngleOrCorner::Corner(horizontal, vertical) => {
+                specified::AngleOrCorner::Corner(horizontal, vertical)
+            }

This is mostly true, you need to change the line to specified::AngleOrCorner::Corner(Some(horizontal), Some(vertical)) because we changed the horizontal and vertical direction to Option in specified.

You can open a WIP PR if you like and we can help you more. It's a bit hard to point a line in this way :)