Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAppveyor windows gnu build is failing #13939
Comments
|
https://ci.appveyor.com/project/servo/servo/history shows that this suddenly broke two days ago. I think something on appveyor's end changed behind our backs? |
|
I think that @metajack was looking into this and there's something related to |
|
well this problem is locally reproducible, it's caused by updating msys git from 2.9.* to 2.10.*, use of official git over msys git solve the problem. |
Remove the mingw git to fix AppVeyor builds <!-- Please describe your changes on the following line: --> Fixes #13939. This is a test, based on @UK992's comment here: #13939 (comment) Please wait for the AppVeyor build to succeed before r+ :-) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14143) <!-- Reviewable:end -->
|
Does that mean that we'll break again if AppVeyor update the git version they provide out of the box? |
|
No. the provided windows git fine. Mingw git broken. See PR removing. On Nov 9, 2016, at 2:53 AM, Ms2ger notifications@github.com wrote: Does that mean that we'll break again if AppVeyor update the git version — |
…om larsbergstrom:git_fix_appveyor); r=notriddle <!-- Please describe your changes on the following line: --> Fixes #13939. This is a test, based on @UK992's comment here: servo/servo#13939 (comment) Please wait for the AppVeyor build to succeed before r+ :-) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 3b298564e126992f8301980b7213495416da60d1
…om larsbergstrom:git_fix_appveyor); r=notriddle <!-- Please describe your changes on the following line: --> Fixes #13939. This is a test, based on UK992's comment here: servo/servo#13939 (comment) Please wait for the AppVeyor build to succeed before r+ :-) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 3b298564e126992f8301980b7213495416da60d1 UltraBlame original commit: 872e122c06bbef67eebbe84994d7379cf6484a3a
…om larsbergstrom:git_fix_appveyor); r=notriddle <!-- Please describe your changes on the following line: --> Fixes #13939. This is a test, based on UK992's comment here: servo/servo#13939 (comment) Please wait for the AppVeyor build to succeed before r+ :-) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 3b298564e126992f8301980b7213495416da60d1 UltraBlame original commit: 872e122c06bbef67eebbe84994d7379cf6484a3a
…om larsbergstrom:git_fix_appveyor); r=notriddle <!-- Please describe your changes on the following line: --> Fixes #13939. This is a test, based on UK992's comment here: servo/servo#13939 (comment) Please wait for the AppVeyor build to succeed before r+ :-) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 3b298564e126992f8301980b7213495416da60d1 UltraBlame original commit: 872e122c06bbef67eebbe84994d7379cf6484a3a
I'm not sure when this changed, but I guess the appveyor build folder isn't a git repo, for some reason?