Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor windows gnu build is failing #13939

Closed
jdm opened this issue Oct 27, 2016 · 7 comments
Closed

Appveyor windows gnu build is failing #13939

jdm opened this issue Oct 27, 2016 · 7 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 27, 2016

I'm not sure when this changed, but I guess the appveyor build folder isn't a git repo, for some reason?

if %BUILD_ENV%==gnu  bash -lc "cd $APPVEYOR_BUILD_FOLDER; ./mach build -d -v && ./mach test-unit"
Error running mach:
    ['build', '-d', '-v']
The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You should consider filing a bug for this issue.
If filing a bug, please include the full output of mach, including this error
message.
The details of the failure are as follows:
CalledProcessError: Command '['git', 'rev-parse', '--short', 'HEAD']' returned non-zero exit status 127
  File "/c/projects/servo/python/servo/build_commands.py", line 217, in build
    env = self.build_env(target=target, is_build=True)
  File "/c/projects/servo/python/servo/command_base.py", line 485, in build_env
    'git', 'rev-parse', '--short', 'HEAD'
  File "/usr/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
@highfive
Copy link

@highfive highfive commented Oct 27, 2016

@jdm
Copy link
Member Author

@jdm jdm commented Oct 27, 2016

https://ci.appveyor.com/project/servo/servo/history shows that this suddenly broke two days ago. I think something on appveyor's end changed behind our backs?

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Nov 8, 2016

I think that @metajack was looking into this and there's something related to PATH changes. This is under investigation with the appveyor support staff.

@UK992
Copy link
Contributor

@UK992 UK992 commented Nov 8, 2016

well this problem is locally reproducible, it's caused by updating msys git from 2.9.* to 2.10.*, use of official git over msys git solve the problem.
in this appveyor case just removing git from pacman's packages list.

bors-servo added a commit that referenced this issue Nov 9, 2016
Remove the mingw git to fix AppVeyor builds

<!-- Please describe your changes on the following line: -->
Fixes #13939. This is a test, based on @UK992's comment here:
#13939 (comment)

Please wait for the AppVeyor build to succeed before r+ :-)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14143)
<!-- Reviewable:end -->
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 9, 2016

Does that mean that we'll break again if AppVeyor update the git version they provide out of the box?

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Nov 9, 2016

No. the provided windows git fine. Mingw git broken. See PR removing.

On Nov 9, 2016, at 2:53 AM, Ms2ger notifications@github.com wrote:

Does that mean that we'll break again if AppVeyor update the git version
they provide out of the box?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#13939 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAdCx5rQRxuEiGwaEsReXICaWl78D3jXks5q8YoLgaJpZM4Kh9yQ
.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Feb 4, 2017
…om larsbergstrom:git_fix_appveyor); r=notriddle

<!-- Please describe your changes on the following line: -->
Fixes #13939. This is a test, based on @UK992's comment here:
servo/servo#13939 (comment)

Please wait for the AppVeyor build to succeed before r+ :-)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 3b298564e126992f8301980b7213495416da60d1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
…om larsbergstrom:git_fix_appveyor); r=notriddle

<!-- Please describe your changes on the following line: -->
Fixes #13939. This is a test, based on UK992's comment here:
servo/servo#13939 (comment)

Please wait for the AppVeyor build to succeed before r+ :-)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 3b298564e126992f8301980b7213495416da60d1

UltraBlame original commit: 872e122c06bbef67eebbe84994d7379cf6484a3a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
…om larsbergstrom:git_fix_appveyor); r=notriddle

<!-- Please describe your changes on the following line: -->
Fixes #13939. This is a test, based on UK992's comment here:
servo/servo#13939 (comment)

Please wait for the AppVeyor build to succeed before r+ :-)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 3b298564e126992f8301980b7213495416da60d1

UltraBlame original commit: 872e122c06bbef67eebbe84994d7379cf6484a3a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
…om larsbergstrom:git_fix_appveyor); r=notriddle

<!-- Please describe your changes on the following line: -->
Fixes #13939. This is a test, based on UK992's comment here:
servo/servo#13939 (comment)

Please wait for the AppVeyor build to succeed before r+ :-)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 3b298564e126992f8301980b7213495416da60d1

UltraBlame original commit: 872e122c06bbef67eebbe84994d7379cf6484a3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.