Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-follow redirect modes for RequestInit #14018

Closed
Ms2ger opened this issue Nov 2, 2016 · 4 comments
Closed

Support non-follow redirect modes for RequestInit #14018

Ms2ger opened this issue Nov 2, 2016 · 4 comments
Labels
A-network C-assigned

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 2, 2016

(As requested by jdm in #13742.)
@Ms2ger Ms2ger added the A-network label Nov 2, 2016
@jdm jdm added this to the Swiss Hackathon milestone Nov 4, 2016
@jdm
Copy link
Member

@jdm jdm commented Nov 4, 2016

Steps:

Tests:
I would expect new test results to occur when running ./mach test-wpt tests/wpt/web-platform-tests/fetch/api/ after making these changes. They will need to be updated to account for the differences.
@rnestler
Copy link
Contributor

@rnestler rnestler commented Nov 5, 2016

I would like to give this a try as part of the Swiss hackathon 😃.
@rnestler
Copy link
Contributor

@rnestler rnestler commented Nov 5, 2016

@jdm

  • add request_mode member to RequestInit

There is already the pub mode: RequestMode field in RequestInit or did you mean to add a field redirect_mode?
@jdm
Copy link
Member

@jdm jdm commented Nov 5, 2016

Yes, I meant redirect_mode. Sorry!
@rnestler rnestler mentioned this issue Nov 5, 2016
Merged
4 of 4 tasks complete
@jdm jdm added the C-assigned label Nov 5, 2016
bors-servo added a commit that referenced this issue Nov 9, 2016
@bors-servo
Auto merge of #14083 - rnestler:fix_14018, r=jdm
Loading status checks…
1ff364f 
Add redirect_mode to RequestInit

This adds support for non-follow redirect modes for `RequestInit`.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14018 (github issue number if applicable).
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14083)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 9, 2016
@bors-servo
Auto merge of #14083 - rnestler:fix_14018, r=jdm
Loading status checks…
22874ff 
Add redirect_mode to RequestInit

This adds support for non-follow redirect modes for `RequestInit`.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14018 (github issue number if applicable).
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14083)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 10, 2016
@bors-servo
Auto merge of #14083 - rnestler:fix_14018, r=jdm
Loading status checks…
58baf3e 
Add redirect_mode to RequestInit

This adds support for non-follow redirect modes for `RequestInit`.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14018 (github issue number if applicable).
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14083)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-network C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add redirect_mode to RequestInit
3 participants
@jdm @Ms2ger @rnestler
You can’t perform that action at this time.