Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Property hacking guide wiki page up-to-date #14128

Closed
chenpighead opened this issue Nov 8, 2016 · 1 comment
Closed

Keep Property hacking guide wiki page up-to-date #14128

chenpighead opened this issue Nov 8, 2016 · 1 comment

Comments

@chenpighead
Copy link
Contributor

@chenpighead chenpighead commented Nov 8, 2016

An example would be that we're using style_traits::ToCss instead of cssparser::ToCss after #14089.

There could be more, such like when should we setting products="gecko|servo|none"? What should we do if we're adding a longhand property (e.g. font-synthesis) that is included in a shorthand property (e.g. font)?

@wafflespeanut
Copy link
Member

@wafflespeanut wafflespeanut commented Nov 8, 2016

Thanks. I've revised the former, and the latter depends on types (some are implemented in servo, some on gecko, and some are unimplemented in both). So, we'll mention it in the issue next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.