Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect serialization of script contents in innerHTML #14226

Closed
Ms2ger opened this issue Nov 15, 2016 · 1 comment
Closed

Incorrect serialization of script contents in innerHTML #14226

Ms2ger opened this issue Nov 15, 2016 · 1 comment
Labels
A-content/dom I-wrong

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 15, 2016 

<script id="body-idl" type="text/plain">
Promise<ArrayBuffer>
</script>
<script>
console.log(document.getElementById("body-idl").innerHTML)
</script>

yields Promise<ArrayBuffer> in Gecko and Chrome; we return Promise&lt;ArrayBuffer&gt;.
Ms2ger added a commit to web-platform-tests/wpt that referenced this issue Nov 15, 2016
@Ms2ger
Use textContent rather than innerHTML for the fetch IDL tests.
Loading status checks…
b1336d8 
There is no good reason for the extra complexity of invoking the HTML
serializer here. It might catch bugs in the serializer implementation
(as it does in Servo: <servo/servo#14226>),
but that's out of scope for this test.
@Ms2ger Ms2ger mentioned this issue Nov 15, 2016
Merged
jdm added a commit to web-platform-tests/wpt that referenced this issue Nov 15, 2016
@Ms2ger @jdm
Use textContent rather than innerHTML for the fetch IDL tests.
Loading status checks…
56c4029 
There is no good reason for the extra complexity of invoking the HTML
serializer here. It might catch bugs in the serializer implementation
(as it does in Servo: <servo/servo#14226>),
but that's out of scope for this test.
@jdm
Copy link
Member

@jdm jdm commented Mar 3, 2017

Closing in favour of #14975.
@jdm jdm closed this Mar 3, 2017
@jdm jdm mentioned this issue Apr 21, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @Ms2ger
You can’t perform that action at this time.