Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer Either type for UrlOrNone #14298

Closed
wafflespeanut opened this issue Nov 20, 2016 · 3 comments
Closed

Prefer Either type for UrlOrNone #14298

wafflespeanut opened this issue Nov 20, 2016 · 3 comments
Labels
A-content/css A-stylo C-assigned E-easy I-cleanup

Comments

@wafflespeanut
Copy link
Member

@wafflespeanut wafflespeanut commented Nov 20, 2016 •
edited

We have an enum UrlOrNone here. This should really be a type alias of Either<SpecifiedUrl, None_> instead. We already have a similar alias for LengthOrNone here, which should help. Once that's been done, the ToCss and the parse impls can then be removed.
@highfive
Copy link

@highfive highfive commented Nov 20, 2016

Please make a comment here if you intend to work on this issue. Thank you!
@thiagopnts
Copy link
Contributor

@thiagopnts thiagopnts commented Nov 20, 2016

I'll be working on this one
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Nov 21, 2016

Go right ahead!
@KiChjang KiChjang added the C-assigned label Nov 21, 2016
@thiagopnts thiagopnts mentioned this issue Nov 25, 2016
Merged
2 of 5 tasks complete
bors-servo added a commit that referenced this issue Dec 1, 2016
@bors-servo
Auto merge of #14370 - thiagopnts:master, r=Wafflespeanut
Loading status checks…
8c3b88d 
use Either type for UrlOrNone

Use the Either type for UrlOrNone

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #14298 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14370)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 2, 2016
@bors-servo
Auto merge of #14370 - thiagopnts:master, r=Wafflespeanut
Loading status checks…
290ff5c 
use Either type for UrlOrNone

Use the Either type for UrlOrNone

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #14298 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14370)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/css A-stylo C-assigned E-easy I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

use Either type for UrlOrNone
4 participants
@thiagopnts @KiChjang @highfive @wafflespeanut
You can’t perform that action at this time.