Update canonicalize_filter spec link and steps #14324
Labels
Comments
3 tasks
bors-servo
pushed a commit
that referenced
this issue
Nov 30, 2016
Annotations for WebBluetooth functions <!-- Please describe your changes on the following line: --> 1. Moved the `convert_request_device_options` function steps into `request_bluetooth_devices` function, to stay consistent with the current specification. 2. Updated the existing step annotations for the requestDevice and related methods. 3. Added step annotations for the implemented WebBluetooth methods. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #14324, #12614 <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14407) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this issue
Nov 30, 2016
Annotations for WebBluetooth functions <!-- Please describe your changes on the following line: --> 1. Moved the `convert_request_device_options` function steps into `request_bluetooth_devices` function, to stay consistent with the current specification. 2. Updated the existing step annotations for the requestDevice and related methods. 3. Added step annotations for the implemented WebBluetooth methods. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #14324, #12614 <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14407) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this issue
Nov 30, 2016
Annotations for WebBluetooth functions <!-- Please describe your changes on the following line: --> 1. Moved the `convert_request_device_options` function steps into `request_bluetooth_devices` function, to stay consistent with the current specification. 2. Updated the existing step annotations for the requestDevice and related methods. 3. Added step annotations for the implemented WebBluetooth methods. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #14324, #12614 <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14407) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this issue
Dec 1, 2016
Annotations for WebBluetooth functions <!-- Please describe your changes on the following line: --> 1. Moved the `convert_request_device_options` function steps into `request_bluetooth_devices` function, to stay consistent with the current specification. 2. Updated the existing step annotations for the requestDevice and related methods. 3. Added step annotations for the implemented WebBluetooth methods. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #14324, #12614 <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14407) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The spec has been updated so we can link to https://webbluetoothcg.github.io/web-bluetooth/#bluetoothlescanfilterinit-canonicalizing instead, and renumber the steps appropriately.
cc @dati91 @zakorgy
The text was updated successfully, but these errors were encountered: