Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upget_primary_service doesn't check blocklist or allowed services #14409
Labels
Comments
|
get_included_service seems to also be missing these checks. |
|
What is the purpose of checking the blocklist in get_primary_services, in that case? |
|
Disregard that question, I read the code and it makes more sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The spec annotation steps in #14407 helped me realize that get_primary_service and get_primary_services implement the same algorithm but have different behaviour. The spec says that the service returned from get_primary_service should not be blocklisted and should be in the list of allowed services.
cc @dati91 @zakorgy