Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_primary_service doesn't check blocklist or allowed services #14409

Closed
jdm opened this issue Nov 29, 2016 · 4 comments
Closed

get_primary_service doesn't check blocklist or allowed services #14409

jdm opened this issue Nov 29, 2016 · 4 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Nov 29, 2016

The spec annotation steps in #14407 helped me realize that get_primary_service and get_primary_services implement the same algorithm but have different behaviour. The spec says that the service returned from get_primary_service should not be blocklisted and should be in the list of allowed services.

cc @dati91 @zakorgy

@jdm
Copy link
Member Author

@jdm jdm commented Nov 29, 2016

get_included_service seems to also be missing these checks.

@dati91
Copy link
Contributor

@dati91 dati91 commented Nov 29, 2016

We check for blocklist here and for the allowed services here.

@jdm
Copy link
Member Author

@jdm jdm commented Nov 29, 2016

What is the purpose of checking the blocklist in get_primary_services, in that case?

@jdm
Copy link
Member Author

@jdm jdm commented Nov 29, 2016

Disregard that question, I read the code and it makes more sense.

@jdm jdm closed this Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.