Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "browsing context names" concept. #14453

Closed
frewsxcv opened this issue Dec 3, 2016 · 3 comments
Closed

Implement "browsing context names" concept. #14453

frewsxcv opened this issue Dec 3, 2016 · 3 comments

Comments

@frewsxcv frewsxcv changed the title Implement named browsing contexts. Implement "browsing context names" concept. Dec 3, 2016
bors-servo added a commit that referenced this issue Dec 4, 2016
…2ger

Add tracking issues for DOM APIs related to 'browsing context names'.

#14453

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14454)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Feb 4, 2017
…owsing context names' (from frewsxcv:named-browsing-context-tracking); r=Ms2ger

servo/servo#14453

Source-Repo: https://github.com/servo/servo
Source-Revision: 07a3e9b2266c87493cb70c6f50e36a0d2dfe8a66
@jdm
Copy link
Member

@jdm jdm commented Feb 6, 2018

@paavininanda This would be a useful feature to add support for. There are a few parts to it that can be done separately:

  • add the basic support for getting and setting Window.name
    • update Window.webidl to uncomment the name attribute
    • store a string member in components/script/dom/windowproxy.rs
    • have Window::GetName and Window::SetName interact with the window proxy
  • support HTMLIFrameElement.name
    • uncomment the attribute from HTMLIFrameElement.webidl
    • have the getter and setter interact with the window proxy for the window inside the iframe
  • notify the constellation whenever a window's name is updated
    • when setting from the iframe, send a message to the child window to ensure it receives the new name
    • when setting from the window, send a message to the parent iframe to ensure it receives the new name
@paavininanda
Copy link
Contributor

@paavininanda paavininanda commented Feb 11, 2018

@jdm I would like to take up this issue.
Now for the SetName function, do i need to check any validity for U+005F LOW LINE characters ? Because I could't find any example where window.name="something" would throw an error in Chrome.

@jdm
Copy link
Member

@jdm jdm commented Feb 11, 2018

No. There are no checks anywhere whether the name matches the restrictions of a valid browsing context name.

@jdm jdm added the C-assigned label Feb 11, 2018
@paavininanda paavininanda mentioned this issue Feb 13, 2018
3 of 5 tasks complete
bors-servo added a commit that referenced this issue Feb 22, 2018
Browsing context names

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14453

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20036)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 26, 2018
Browsing context names

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14453

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20036)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Feb 26, 2018
…ingNames); r=jdm

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix servo/servo#14453

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 7de2043b9c565fe1afc704cca9461cb08fccd67c

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 328d6447a3831f9742280013919e37b3f4b7a346
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
…owsing context names' (from frewsxcv:named-browsing-context-tracking); r=Ms2ger

servo/servo#14453

Source-Repo: https://github.com/servo/servo
Source-Revision: 07a3e9b2266c87493cb70c6f50e36a0d2dfe8a66

UltraBlame original commit: 190e7a2c6cf7ac9ce43d7394cad4249d079bd378
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
…owsing context names' (from frewsxcv:named-browsing-context-tracking); r=Ms2ger

servo/servo#14453

Source-Repo: https://github.com/servo/servo
Source-Revision: 07a3e9b2266c87493cb70c6f50e36a0d2dfe8a66

UltraBlame original commit: 190e7a2c6cf7ac9ce43d7394cad4249d079bd378
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
…owsing context names' (from frewsxcv:named-browsing-context-tracking); r=Ms2ger

servo/servo#14453

Source-Repo: https://github.com/servo/servo
Source-Revision: 07a3e9b2266c87493cb70c6f50e36a0d2dfe8a66

UltraBlame original commit: 190e7a2c6cf7ac9ce43d7394cad4249d079bd378
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 2, 2019
…ingNames); r=jdm

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix servo/servo#14453

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 7de2043b9c565fe1afc704cca9461cb08fccd67c

UltraBlame original commit: c39af4d010d51ad06339162c7b9a5f7c2c50553f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 2, 2019
…ingNames); r=jdm

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix servo/servo#14453

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 7de2043b9c565fe1afc704cca9461cb08fccd67c

UltraBlame original commit: c39af4d010d51ad06339162c7b9a5f7c2c50553f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 2, 2019
…ingNames); r=jdm

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix servo/servo#14453

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 7de2043b9c565fe1afc704cca9461cb08fccd67c

UltraBlame original commit: c39af4d010d51ad06339162c7b9a5f7c2c50553f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.