Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement domain and path checks from https-cookie-alone-01 #14477

Closed
jdm opened this issue Dec 7, 2016 · 1 comment
Closed

Implement domain and path checks from https-cookie-alone-01 #14477

jdm opened this issue Dec 7, 2016 · 1 comment
Assignees
@KiChjang
Labels
A-network A-security C-assigned

Comments

@jdm
Copy link
Member

@jdm jdm commented Dec 7, 2016

https://www.ietf.org/id/draft-ietf-httpbis-cookie-alone-01.txt defines some steps to choose when cookies are valid choices to be evicted by a newer cookie. #14445 implemented some parts of this specification (specifically, ensuring that insecure cookies cannot evict secure cookies), but we still need to implement the more specific domain and path-matching checks.
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Dec 7, 2016

Taking a look at this.
@KiChjang KiChjang self-assigned this Dec 7, 2016
@KiChjang KiChjang added the C-assigned label Dec 7, 2016
@KiChjang KiChjang mentioned this issue Dec 8, 2016
Merged
bors-servo added a commit that referenced this issue Dec 23, 2016
@bors-servo
Auto merge of #14491 - KiChjang:cookie-checks, r=jdm
Loading status checks…
b13afcc 
Add domain and path checks for secure cookies eviction

Fixes #14477.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14491)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KiChjang KiChjang

Labels
A-network A-security C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @KiChjang
You can’t perform that action at this time.