Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upassertion failed: !self.scroll_roots.contains_key(&scroll_root.id) #14574
Assignees
Comments
|
This seems to be an issue where a particular node is producing more than one Flow and also starting a scroll root. I didn't realize this could happen. I believe I have a solution that will both fix this issue and also make possibly make incremental display list construction possible. This also fits in well with work that I'm already doing, so I hope to have a PR for this issue soon. |
|
Okay. I did some more digging with this issue. The root of the problem is that a table on the page somehow has it's overflow style resolved to "auto." This causes Servo to attempt to create a scrolling root for the table wrapper as well as the table. Judging by https://bugzilla.mozilla.org/show_bug.cgi?id=26617 it seems that tables should never respect overflow:scroll or overflow:auto, so I think there's a deeper issue here. Quite likely, we should just avoid respecting those properties when they are applied to tables. |
|
Here's a reduced test case: I'm testing a fix for this now. |
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
Jan 10, 2017
Only create scroll roots for overflow regions when the overflow region is actually larger than the container size. This prevents creating scrolling roots for elements that do not have overflow scroll as a side-effect of the way their height and width is defined. For example, tables should never respect overflow:scroll since their height and width should always be large enough to prevent overflow. This also decreases the size and complexity of the display list in many other circumstances. Fixes servo#14574.
|
A fix is available in the branch at https://github.com/mrobinson/servo/tree/scroll-roots-when-necessary, but it depends on #14603. Hopefully I can get that reviewed today or tomorrow. |
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
Jan 10, 2017
Only create scroll roots for overflow regions when the overflow region is actually larger than the container size. This prevents creating scrolling roots for elements that do not have overflow scroll as a side-effect of the way their height and width is defined. For example, tables should never respect overflow:scroll since their height and width should always be large enough to prevent overflow. This also decreases the size and complexity of the display list in many other circumstances. As part of this change, transformed overflow calculation is moved from display list construction to layout. This should mean that overflow is handled more accurately earlier. Fixes servo#14574.
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
Jan 10, 2017
Only create scroll roots for overflow regions when the overflow region is actually larger than the container size. This prevents creating scrolling roots for elements that do not have overflow scroll as a side-effect of the way their height and width is defined. For example, tables should never respect overflow:scroll since their height and width should always be large enough to prevent overflow. This also decreases the size and complexity of the display list in many other circumstances. As part of this change, transformed overflow calculation is moved from display list construction to layout. This should mean that overflow is handled more accurately earlier. Fixes servo#14574.
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
Jan 11, 2017
Only create scroll roots for overflow regions when the overflow region is actually larger than the container size. This prevents creating scrolling roots for elements that do not have overflow scroll as a side-effect of the way their height and width is defined. For example, tables should never respect overflow:scroll since their height and width should always be large enough to prevent overflow. This also decreases the size and complexity of the display list in many other circumstances. As part of this change, transformed overflow calculation is moved from display list construction to layout. This should mean that overflow is handled more accurately earlier. Fixes servo#14574.
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
Jan 12, 2017
Only create scroll roots for overflow regions when the overflow region is actually larger than the container size. This prevents creating scrolling roots for elements that do not have overflow scroll as a side-effect of the way their height and width is defined. For example, tables should never respect overflow:scroll since their height and width should always be large enough to prevent overflow. This also decreases the size and complexity of the display list in many other circumstances. As part of this change, transformed overflow calculation is moved from display list construction to layout. This should mean that overflow is handled more accurately earlier. Fixes servo#14574.
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
Jan 12, 2017
Only create scroll roots for overflow regions when the overflow region is actually larger than the container size. This prevents creating scrolling roots for elements that do not have overflow scroll as a side-effect of the way their height and width is defined. For example, tables should never respect overflow:scroll since their height and width should always be large enough to prevent overflow. This also decreases the size and complexity of the display list in many other circumstances. As part of this change, transformed overflow calculation is moved from display list construction to layout. This should mean that overflow is handled more accurately earlier. Fixes servo#14574.
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
Jan 17, 2017
Only create scroll roots for overflow regions when the overflow region is actually larger than the container size. This prevents creating scrolling roots for elements that do not have overflow scroll as a side-effect of the way their height and width is defined. For example, tables should never respect overflow:scroll since their height and width should always be large enough to prevent overflow. This also decreases the size and complexity of the display list in many other circumstances. As part of this change, transformed overflow calculation is moved from display list construction to layout. This should mean that overflow is handled more accurately earlier. Fixes servo#14574.
bors-servo
added a commit
that referenced
this issue
Jan 17, 2017
Only create scrolling overflow regions when necessary Only create scroll roots for overflow regions when the overflow region is actually larger than the container size. This prevents creating scrolling roots for elements that do not have overflow scroll as a side-effect of the way their height and width is defined. For example, tables should never respect overflow:scroll since their height and width should always be large enough to prevent overflow. This also decreases the size and complexity of the display list in many other circumstances. As part of this change, transformed overflow calculation is moved from display list construction to layout. This should mean that overflow is handled more accurately earlier. Fixes #14574. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #14574 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14979) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cc @mrobinson