Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser_inserted fields should probably be resetted when unbound from the tree. #14616

Closed
emilio opened this issue Dec 16, 2016 · 2 comments
Closed

Comments

@emilio
Copy link
Member

@emilio emilio commented Dec 16, 2016

There are a few elements (currently script and link, also style with #14540) that track whether they've been injected by the parser.

The link element's field is never set back to false, and the script field should probably be set to false also after unbinding from the tree.

Presumably somebody could write an script that grabs a loaded link element, then re-inserts it with a different href, and that probably shouldn't be script blocking.

Is that right?

cc @Ms2ger and @jdm, which probably know more about script-blocking loads than I.

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Dec 19, 2016

Should review what, if anything, the spec says, and what other browsers do.

@jdm jdm removed the A-network label Jan 4, 2017
@nox
Copy link
Member

@nox nox commented Oct 7, 2017

It's not reset after unbinding because the spec doesn't say it should be reset. I reviewed most of that when doing parser changes and document.write, and I'm 99.44% sure this should not be done. Closing this issue.

@nox nox closed this Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.