Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement OffscreenCanvas API (needed for WebGL canvas in workers) #14627

Open
cvan opened this issue Dec 19, 2016 · 4 comments
Open

Implement OffscreenCanvas API (needed for WebGL canvas in workers) #14627

cvan opened this issue Dec 19, 2016 · 4 comments
Labels
A-content/canvas B-interesting-project
Projects
Mixed Reality future needs

Comments

@cvan
Copy link

@cvan cvan commented Dec 19, 2016

The OffscreenCanvas API supports a canvas to be rendered off screen. It is available in both the window and worker contexts.

Supported by a flag today in Firefox, under active development right now by Chrome.

Relevant links:
@cvan cvan mentioned this issue Dec 19, 2016
Merged
3 of 5 tasks complete
@jdm
Copy link
Member

@jdm jdm commented Jan 4, 2017

I believe this needs to wait for support for transferable objects, otherwise there's no way to obtain the canvas in the worker.
@cvan
Copy link
Author

@cvan cvan commented Jan 13, 2017

I believe this needs to wait for support for transferable objects, otherwise there's no way to obtain the canvas in the worker.

Are there issues on file for this? I'm curious to learn more.
@jdm
Copy link
Member

@jdm jdm commented Jan 13, 2017

#15021
@jdm
Copy link
Member

@jdm jdm commented Jan 4, 2018

#19067 was an in-progress effort to support some of the OffscreenCanvas APIs.
@jdm jdm moved this from To Do to Unsure if needed in Mixed Reality future needs Mar 21, 2018
@PrayaniSingh0106 PrayaniSingh0106 mentioned this issue Nov 10, 2018
Closed
1 of 5 tasks complete
@maharsh312 maharsh312 mentioned this issue Dec 19, 2018
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Jan 9, 2019
@bors-servo
Auto merge of #22495 - maharsh312:master, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8ef1072 
OffscreenCanvas API

<!-- Please describe your changes on the following line: -->
Initial Steps for OffscreenCanvas API are done in this commit.

r? @jdm
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14627 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22495)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 16, 2019
@bors-servo
Auto merge of #22495 - maharsh312:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
287dc47 
OffscreenCanvas API

<!-- Please describe your changes on the following line: -->
Initial Steps for OffscreenCanvas API are done in this commit.

r? @jdm
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14627 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22495)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 16, 2019
@bors-servo
Auto merge of #22495 - maharsh312:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e073ed2 
OffscreenCanvas API

<!-- Please describe your changes on the following line: -->
Initial Steps for OffscreenCanvas API are done in this commit.

r? @jdm
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14627 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22495)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 16, 2019
@bors-servo
Auto merge of #22495 - maharsh312:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
41181e3 
OffscreenCanvas API

<!-- Please describe your changes on the following line: -->
Initial Steps for OffscreenCanvas API are done in this commit.

r? @jdm
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14627 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22495)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 16, 2019
@bors-servo
Auto merge of #22495 - maharsh312:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f5cecfc 
OffscreenCanvas API

<!-- Please describe your changes on the following line: -->
Initial Steps for OffscreenCanvas API are done in this commit.

r? @jdm
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14627 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22495)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 16, 2019
@bors-servo
Auto merge of #22495 - maharsh312:master, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
09cdcab 
OffscreenCanvas API

<!-- Please describe your changes on the following line: -->
Initial Steps for OffscreenCanvas API are done in this commit.

r? @jdm
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14627 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22495)
<!-- Reviewable:end -->
@jdm jdm reopened this Jan 16, 2019
@jdm jdm moved this from Unsure if needed to In Progress in Mixed Reality future needs Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/canvas B-interesting-project
Projects
Mixed Reality future needs
  
In Progress
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

OffscreenCanvas API
3 participants
@jdm @nox @cvan
You can’t perform that action at this time.