Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Windows nightly builders for consistency #14670

Merged

Conversation

aneeshusa
Copy link
Contributor

@aneeshusa aneeshusa commented Dec 22, 2016

Fixup for #14651. r? @larsbergstrom


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because these builders aren't used yet

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 22, 2016
@larsbergstrom
Copy link
Contributor

@bors-servo r+

hrm, I must not have pushed -f the fixes on the PR branch? I'm very confused now why that didn't land because I have it locally :-/ Thanks for catching!

@bors-servo
Copy link
Contributor

📌 Commit c865515 has been approved by larsbergstrom

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 22, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit c865515 with merge 5573f7c...

bors-servo pushed a commit that referenced this pull request Dec 22, 2016
…=larsbergstrom

Rename Windows nightly builders for consistency

<!-- Please describe your changes on the following line: -->

Fixup for #14651. r? @larsbergstrom

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because these builders aren't used yet

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14670)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo merged commit c865515 into servo:master Dec 22, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants