Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate the version of brotli used in the network code #14681
Closed
Comments
|
Please make a comment here if you intend to work on this issue. Thank you! |
jdm
changed the title
bors-servo
added a commit
that referenced
this issue
Dec 23, 2016
Update various crates. Fixes #14681. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14687) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Dec 24, 2016
Update various crates. Fixes #14681. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14687) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a rare issue that could cause the brotli 1.0.6 crate to fail to decode a valid brotli file downloaded with server-side brotli compression enabled. The bug stemmed from break failing to exit the outer for loop when a series of C gotos were converted into rust switches/loops
The issue has been resolved in 1.0.7 and 1.0.7 has been successfully tested on over 10 million files with a large variety of brotli compressor settings.
it would be ideal to bump the crate version servo uses from 1.0.6 to 1.0.7 in this file
servo/components/net/Cargo.toml
Line 14 in 4eb6538
to the newest here
https://crates.io/crates/brotli