Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement display: inline-flex #14685

Closed
shinglyu opened this issue Dec 23, 2016 · 5 comments
Closed

Implement display: inline-flex #14685

shinglyu opened this issue Dec 23, 2016 · 5 comments
Assignees

Comments

@shinglyu
Copy link
Member

@shinglyu shinglyu commented Dec 23, 2016

No description provided.

@shinglyu shinglyu self-assigned this Dec 23, 2016
@shinglyu
Copy link
Member Author

@shinglyu shinglyu commented Dec 23, 2016

cc @stshine
I'm blocked on #12610 for too long. I'll try to work on this to get some fresh perspective.

1 similar comment
@shinglyu
Copy link
Member Author

@shinglyu shinglyu commented Dec 23, 2016

cc @stshine
I'm blocked on #12610 for too long. I'll try to work on this to get some fresh perspective.

@shinglyu
Copy link
Member Author

@shinglyu shinglyu commented Dec 27, 2016

Here are a list of testcases that can potentially be fixed by implementing display: inline-flex

display_inline-flex_exist.htm
flexbox-align-self-horiz-001-block.htm
flexbox-align-self-horiz-001-table.htm
flexbox-align-self-horiz-002.htm
flexbox-align-self-horiz-003.htm
flexbox-align-self-horiz-004.htm
flexbox-baseline-align-self-baseline-horiz-001.htm
flexbox-baseline-align-self-baseline-vert-001.htm
flexbox-baseline-empty-001a.htm
flexbox-baseline-empty-001b.htm
flexbox-baseline-multi-item-horiz-001.htm
flexbox-baseline-multi-item-vert-001.htm
flexbox-baseline-multi-line-horiz-001.htm
flexbox-baseline-multi-line-horiz-002.htm
flexbox-baseline-multi-line-horiz-003.htm
flexbox-baseline-multi-line-horiz-004.htm
flexbox-baseline-multi-line-vert-001.htm
flexbox-baseline-multi-line-vert-002.htm
flexbox-baseline-single-item-001a.htm
flexbox-baseline-single-item-001b.htm
flexbox_computedstyle_display-inline.htm
flexbox_inline.htm
flexbox-paint-ordering-001.htm
flexbox-paint-ordering-002.htm
ttwf-reftest-flex-inline.htm
@stshine
Copy link
Contributor

@stshine stshine commented Dec 28, 2016

Go for it! You should need something like InlineBlockFragmentInfo and SpecificFragmentInfo::InlineBlock, but contains a FlexFlow, and process them in inline.rs.

@shinglyu
Copy link
Member Author

@shinglyu shinglyu commented Jan 11, 2017

Almost got it working, however if the flex items are inline element, they didn't get blockified. Currently the patch fixed 5 reftest with no regression.

@shinglyu shinglyu mentioned this issue Jan 12, 2017
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jan 23, 2017
Implemented display: inline-flex

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14685 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14978)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 23, 2017
Implemented display: inline-flex

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14685 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14978)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.