Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming of the constellation's frame tree #14690

Closed
asajeffrey opened this issue Dec 23, 2016 · 5 comments
Closed

Naming of the constellation's frame tree #14690

asajeffrey opened this issue Dec 23, 2016 · 5 comments
Assignees
@asajeffrey
Labels
A-constellation I-cleanup

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Dec 23, 2016

The naming of frames isn't as spec-compliant as it could be: prev is the past, next is the future, FrameState is a session history entry, Frame is the session history of a browsing context.
@asajeffrey asajeffrey self-assigned this Dec 23, 2016
@asajeffrey asajeffrey mentioned this issue Dec 23, 2016
Merged
3 of 3 tasks complete
@cbrewster
Copy link
Member

@cbrewster cbrewster commented Dec 28, 2016

Along with this, we call FrameStates entrys and sometimes states, we should figure out a consistent naming for this.
@cbrewster
Copy link
Member

@cbrewster cbrewster commented Jun 20, 2017

We have done a bit of renaming already, are there any other things left to rename?
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Jun 20, 2017

In my braver moments, I have thought that PipelineId should really be DocumentId or WindowId. But I think we're probably not going to do that.
@nox
Copy link
Member

@nox nox commented Oct 7, 2017

Was this done? If you specified all the renames you want, this could be E-Easy.
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Oct 9, 2017

We did most of the worst offenders. There's still PipelineId but I don't think we should touch this right now.
@asajeffrey asajeffrey closed this Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asajeffrey asajeffrey

Labels
A-constellation I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@nox @asajeffrey @cbrewster
You can’t perform that action at this time.