Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split off Frame from constellation.rs #14691

Closed
asajeffrey opened this issue Dec 23, 2016 · 3 comments
Closed

Split off Frame from constellation.rs #14691

asajeffrey opened this issue Dec 23, 2016 · 3 comments

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Dec 23, 2016

In the same way as EventLoop and Pipeline get their own modules in the constellation, so should Frame.

@yysung1123
Copy link
Contributor

@yysung1123 yysung1123 commented Dec 27, 2016

Is the only thing should be done to move the code "struct Frame..." from constellation.rs to frame.rs?

@yysung1123
Copy link
Contributor

@yysung1123 yysung1123 commented Dec 27, 2016

I'd like to work on this issue!

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Dec 27, 2016

Yep, the struct and the impl blocks; go ahead!

@yysung1123 yysung1123 mentioned this issue Dec 27, 2016
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Dec 27, 2016
…Wafflespeanut

Move frame from constellation

<!-- Please describe your changes on the following line: -->

Move frame from constellation

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14691  (github issue number if applicable).

<!-- Either: -->
- [X] These changes do not require tests

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.