Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FrameChange::document_ready is never set #14693

Closed
asajeffrey opened this issue Dec 23, 2016 · 3 comments
Closed

FrameChange::document_ready is never set #14693

asajeffrey opened this issue Dec 23, 2016 · 3 comments
Assignees
@asajeffrey
Labels
A-constellation E-easy I-cleanup

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Dec 23, 2016 •
edited by jdm

FrameChange::document_ready is initialized false and never set true. We can remove it.

Code: components/constellation/constellation.rs
@asajeffrey asajeffrey self-assigned this Dec 23, 2016
@asajeffrey asajeffrey added the E-easy label Dec 23, 2016
@highfive
Copy link

@highfive highfive commented Dec 23, 2016

Please make a comment here if you intend to work on this issue. Thank you!
@asajeffrey asajeffrey mentioned this issue Dec 23, 2016
Merged
3 of 3 tasks complete
@zaynetro
Copy link

@zaynetro zaynetro commented Dec 25, 2016

I'd like to work on this issue
@zaynetro zaynetro mentioned this issue Dec 25, 2016
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Dec 25, 2016
@bors-servo
Auto merge of #14724 - zaynetro:remove-frame-change-document-ready, r…
Loading status checks…
61d8f4d 
…=Ms2ger

Remove FrameChange::document_ready

<!-- Please describe your changes on the following line: -->

Remove unused `FrameChange::document_ready` field and remove unused boolean in `ConstellationMsg::GetPipeline`'s second argument.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14693

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because compiler validates the field is not used anywhere

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14724)
<!-- Reviewable:end -->
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Dec 25, 2016

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asajeffrey asajeffrey

Labels
A-constellation E-easy I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Remove FrameChange::document_ready
3 participants
@asajeffrey @zaynetro @highfive
You can’t perform that action at this time.