Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move reg_host from the constellation to net_traits #14696

Closed
asajeffrey opened this issue Dec 23, 2016 · 1 comment
Closed

Move reg_host from the constellation to net_traits #14696

asajeffrey opened this issue Dec 23, 2016 · 1 comment
Assignees
@asajeffrey
Labels
A-constellation I-refactor

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Dec 23, 2016

The reg_host function should be in net_traits::pub_domains, not constellation.
@asajeffrey asajeffrey self-assigned this Dec 23, 2016
@asajeffrey asajeffrey mentioned this issue Dec 23, 2016
Merged
3 of 3 tasks complete
@yysung1123
Copy link
Contributor

@yysung1123 yysung1123 commented Dec 26, 2016

I'd like to work on this issue!
@yysung1123 yysung1123 mentioned this issue Dec 26, 2016
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Dec 26, 2016
@bors-servo
Auto merge of #14736 - deror1869107:Move-reg_host-to-pub_domains, r=M…
Loading status checks…
c2448d3 
…s2ger

Move reg_host from the constellation to net_traits

<!-- Please describe your changes on the following line: -->

Move reg_host from the constellation to net_traits

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14696  (github issue number if applicable).

<!-- Either: -->
- [X] These changes do not require tests

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14736)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asajeffrey asajeffrey

Labels
A-constellation I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Move reg_host from the constellation to net_traits
2 participants
@asajeffrey @yysung1123
You can’t perform that action at this time.