Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd HTTP connector to HttpState, instead of creating one in http_network_fetch #14697
Labels
Comments
|
Please make a comment here if you intend to work on this issue. Thank you! |
|
I would like to work on this. |
|
Go for it! Ask any questions here or on |
bors-servo
added a commit
that referenced
this issue
Dec 27, 2016
Reuse the http connector pool between fetches <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #14697 <!-- Either: --> - [x] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14741) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Dec 27, 2016
Reuse the http connector pool between fetches <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #14697 <!-- Either: --> - [x] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14741) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now we are not pooling HTTP connections, because we create a new pool for every connection. If we add the pool to the
HttpStatestructure, we can use it fromhttp_network_fetchinstead of creating it.Code:
components/net/resource_thread.rs,components/net/http_loader.rsTests:
./mach test-wpt tests/wpt/web-platform-tests/XMLHttpRequest(this will ensure that network connections keep working after the change)